Repository navigation
fix(hipblaslt): revert gfx950 HAS_SAV user args logic update - #12018
Merged
Merged
Conversation
Revert the gfx950 HAS_SAV_UserArgs logic changes from 8d9e03f which caused all six gfx950 hipBLASLt standard test shards to abort with GPU memory access faults in the TheRock Multi-Arch CI triage runs. Restoring these seven gfx950 logic YAML files to their pre-11925 state made the scoped gfx950 hipBLASLt standard suite pass again on top of the current failing tip. Fixes #12016
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (35.23%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #12018 +/- ##
===========================================
- Coverage 70.23% 70.23% -0.00%
===========================================
Files 2810 2810
Lines 462535 462535
Branches 68105 68105
===========================================
- Hits 324828 324821 -7
- Misses 114187 114191 +4
- Partials 23520 23523 +3
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Squash and merging this revert with override to unblock submodule bumps on TheRock. |
Contributor
TheRock Submodule Bump ActivityNewest first
|
4 of 6 tasks
amd-chiranjeevi
added
the
bump-pr-revert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts PR: #11925
Fixes Issue: #12016
Motivation
Revert the gfx950 hipBLASLt
HAS_SAV_UserArgslogic update from #11925 because it causes all six gfx950 hipBLASLt standard test shards to abort with GPU memory access faults in TheRock Multi-Arch CI.This is blocking the rocm-libraries submodule bump in ROCm/TheRock#8166 and ROCm/TheRock#8172.
Triage
Scoped TheRock Multi-Arch CI was run with:
linux_amdgpu_families=gfx950linux_test_labels=test:hipblaslt,test_filter:standard9637ceab04158d9e03f56d7ba3eb50b9ea867b612d4c5667The failing shard logs show
hipblaslt-test_standard_suiteaborting after gfx950 GPU memory access faults in generatedISA950matmul cases from theHAS_SAV_UserArgsarea.Fixes #12016