Repository navigation
fix(hipblaslt): tolerate AMDSMI_STATUS_NOT_SUPPORTED for BDF-based device matching on WSL #11987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tony-davis
merged 2 commits into
develop
from
users/tony-davis/fix-wsl-amdsmi-not-supported-crash
Sep 14, 2026
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
projects/hipblaslt/clients/tests/src/efficiency_monitor_gtest.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| // Copyright Advanced Micro Devices, Inc., or its affiliates. | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| // Host-only smoke test: AMD-SMI status classification for optional telemetry | ||
| // (ROCM-30983). Pure logic, no HIP/AMDSMI device calls. | ||
|
|
||
| #include "efficiency_monitor.hpp" | ||
|
|
||
| #include <gtest/gtest.h> | ||
|
|
||
| // isAmdsmiTelemetryUnavailable() and the AMD-SMI status enum it classifies are | ||
| // only declared under !_WIN32 (efficiency_monitor.hpp mirrors the platform | ||
| // split already in efficiency_monitor.cpp; AMD-SMI is not used on Windows). | ||
| #ifndef _WIN32 | ||
| namespace | ||
| { | ||
| TEST(EfficiencyMonitorSmoke, NotSupportedIsTolerated) | ||
| { | ||
| EXPECT_TRUE(isAmdsmiTelemetryUnavailable(AMDSMI_STATUS_NOT_SUPPORTED)); | ||
|
tony-davis marked this conversation as resolved.
Resolved
|
||
| } | ||
|
|
||
| TEST(EfficiencyMonitorSmoke, SuccessIsNotTelemetryUnavailable) | ||
| { | ||
| EXPECT_FALSE(isAmdsmiTelemetryUnavailable(AMDSMI_STATUS_SUCCESS)); | ||
| } | ||
|
|
||
| TEST(EfficiencyMonitorSmoke, OtherFailuresStayFatal) | ||
| { | ||
| EXPECT_FALSE(isAmdsmiTelemetryUnavailable(AMDSMI_STATUS_UNKNOWN_ERROR)); | ||
| } | ||
| } // namespace | ||
| #endif // !_WIN32 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.