Skip to content

feat(tensilelite): add gfx1250 Gate residual support - #11887

Merged
alex391a merged 4 commits into
developfrom
users/alex391a/gate_res_gfx1250
Sep 16, 2026
Merged

alex391a merged 4 commits into
developfrom
users/alex391a/gate_res_gfx1250

Conversation

@alex391a

@alex391a alex391a commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

JIRA ID : AIHPSPAR-274

Motivation

Add gfx1250 support for Gate residual cache hints and correct Gate address updates for compact loop store (CLS).

Technical Details

  • Add gfx1250 packed FMA mappings in stinkytofu.
  • Add TemporalHintGate and NonVolatileGate.
  • Fix Gate row-pointer and SRD updates for CLS.
  • Add FP8 and FP16 sparse GEMM test configurations.

Test Plan

Add Tensile/Tests/common/sparse/gfx1250/spmm_gate.yaml covering FP8 and FP16 Gate residual cases.

Test Result

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@codecov

codecov Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...blaslt/tensilelite/Tensile/KernelWriterAssembly.py 0.00% 5 Missing and 1 partial ⚠️
...tensilelite/Tensile/Components/GlobalWriteBatch.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11887      +/-   ##
===========================================
- Coverage    70.23%   70.22%   -0.01%     
===========================================
  Files         2810     2810              
  Lines       462535   462588      +53     
  Branches     68103    68118      +15     
===========================================
+ Hits        324833   324840       +7     
- Misses      114182   114230      +48     
+ Partials     23520    23518       -2     
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 46.40% <ø> (ø)
TensileLite-Unit 76.07% <20.00%> (-0.01%) ⬇️
hipBLAS 90.62% <ø> (ø) Carriedforward from 62d6012
hipBLASLt 35.20% <ø> (-0.04%) ⬇️
hipCUB 82.68% <ø> (ø) Carriedforward from 62d6012
hipDNN 87.02% <ø> (ø) Carriedforward from 62d6012
hipFFT 43.07% <ø> (ø) Carriedforward from 62d6012
hipRAND 76.12% <ø> (ø) Carriedforward from 62d6012
hipSOLVER 68.92% <ø> (ø) Carriedforward from 62d6012
hipSPARSE 86.99% <ø> (ø) Carriedforward from 62d6012
rocBLAS 48.31% <ø> (ø) Carriedforward from 62d6012
rocFFT 47.16% <ø> (ø) Carriedforward from 62d6012
rocRAND 56.90% <ø> (ø) Carriedforward from 62d6012
rocSOLVER 76.83% <ø> (ø) Carriedforward from 62d6012
rocSPARSE 74.61% <ø> (ø) Carriedforward from 62d6012
rocThrust 91.60% <ø> (ø) Carriedforward from 62d6012

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...laslt/tensilelite/Tensile/AsmAddressCalculation.py 61.31% <ø> (ø)
...slt/tensilelite/Tensile/Common/GlobalParameters.py 95.79% <ø> (ø)
...t/tensilelite/Tensile/Common/RequiredParameters.py 100.00% <ø> (ø)
...aslt/tensilelite/Tensile/Common/ValidParameters.py 100.00% <ø> (ø)
...lt/tensilelite/Tensile/SolutionStructs/Solution.py 58.86% <100.00%> (ø)
...tensilelite/Tensile/Components/GlobalWriteBatch.py 69.42% <0.00%> (-0.06%) ⬇️
...blaslt/tensilelite/Tensile/KernelWriterAssembly.py 70.32% <0.00%> (-0.03%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alex391a
alex391a force-pushed the users/alex391a/gate_res_gfx1250 branch from 9e36281 to f9b29ad Compare September 10, 2026 09:31
@alex391a
alex391a force-pushed the users/alex391a/gate_res_gfx1250 branch 4 times, most recently from d5c4e12 to f6afed0 Compare September 14, 2026 01:48
@alex391a
alex391a force-pushed the users/alex391a/gate_res_gfx1250 branch from f6afed0 to e3523f9 Compare September 14, 2026 15:31

@hcman2 hcman2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok if test passed

@alex391a
alex391a merged commit ebd5db8 into develop Sep 16, 2026
182 of 192 checks passed
@alex391a
alex391a deleted the users/alex391a/gate_res_gfx1250 branch September 16, 2026 02:04
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants