Skip to content

test(tensilelite): add common GEMM to comprehensive/full tiers via runs: sub-runs - #11825

Open
archana-ramalingam wants to merge 5 commits into
developfrom
users/aramalin/tensilelite-standard-common
Open

archana-ramalingam wants to merge 5 commits into
developfrom
users/aramalin/tensilelite-standard-common

Conversation

@archana-ramalingam

@archana-ramalingam archana-ramalingam commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

JIRA ID : AIHPBLAS-4510

Motivation

  • gfx1250 common GEMM tests should run in the canonical tier progression so they're covered by nightly (comprehensive) and on-demand (full).

Technical Details

  • Add a common GEMM sub-run to the comprehensive and full tiers in tensilelite/test_categories.yaml via the runs: sub-run mechanism (TheRock [MIOpen] Add gfx950 SystemDB for MI350X/MI355X #8081).
  • Each tier runs two independent pytest invocations: rocisa + TensileLite unit (incl. GPU), and common GEMM — different paths/markers/client args that one -m can't express.
  • quick/standard stay host-only (unchanged from develop)

Test Plan

  • Now: YAML parses; structure correct — quick/standard single host-only, comprehensive/full = runs:[unit, common]
  • Deferred (end-to-end): after [MIOpen] Add gfx950 SystemDB for MI350X/MI355X #8081 + pin bump (so pytest_runner knows runs:), a gfx1250 runner and a >2h comprehensive/full job timeout — run comprehensive on gfx1250 and confirm both sub-runs execute with separate JUnit reports.

Test Result

  • YAML valid; structure verified; standard/quick byte-identical to develop (only comprehensive/full change).
  • On-hardware execution deferred: no gfx1250 runner yet, and TheRock's tensilelite job timeout is a flat 30 min for all non-quick tiers < ~2h common testing needs.

Submission Checklist

Risk level

Low — scoped to the tensilelite standard tier (opt-in; PR default stays quick); no change to quick/comprehensive/full.

@archana-ramalingam
archana-ramalingam requested a review from a team as a code owner September 8, 2026 21:39
@therock-pr-bot

therock-pr-bot Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@codecov

codecov Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project check has failed because the head coverage (46.45%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11825      +/-   ##
===========================================
+ Coverage    69.42%   70.27%   +0.85%     
===========================================
  Files         2828     2810      -18     
  Lines       470113   462487    -7626     
  Branches     69417    68090    -1327     
===========================================
- Hits        326344   324978    -1366     
+ Misses      120066   113948    -6118     
+ Partials     23703    23561     -142     
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 46.45% <ø> (+7.93%) ⬆️
TensileLite-Unit 76.06% <ø> (+<0.01%) ⬆️
hipBLAS 90.62% <ø> (ø) Carriedforward from adfcbae
hipBLASLt 35.23% <ø> (+0.01%) ⬆️
hipCUB 82.68% <ø> (ø) Carriedforward from adfcbae
hipDNN 87.02% <ø> (ø) Carriedforward from adfcbae
hipFFT 42.66% <ø> (ø) Carriedforward from adfcbae
hipRAND 76.12% <ø> (ø) Carriedforward from adfcbae
hipSOLVER 68.92% <ø> (ø) Carriedforward from adfcbae
hipSPARSE 86.99% <ø> (ø) Carriedforward from adfcbae
rocBLAS 48.31% <ø> (ø) Carriedforward from adfcbae
rocFFT 47.78% <ø> (ø) Carriedforward from adfcbae
rocRAND 56.92% <ø> (ø) Carriedforward from adfcbae
rocSOLVER 76.83% <ø> (ø) Carriedforward from adfcbae
rocSPARSE 74.61% <ø> (ø) Carriedforward from adfcbae
rocThrust 91.60% <ø> (ø) Carriedforward from adfcbae

*This pull request uses carry forward flags. Click here to find out more.
see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@archana-ramalingam archana-ramalingam changed the title test(tensilelite): add common GEMM tests to the standard tier via runs: sub-runs test(tensilelite): add common GEMM to comprehensive/full tiers via runs: sub-runs Sep 10, 2026

@geomin12 geomin12 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will defer reviews to hipblaslt team

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants