Skip to content

[MIOpen] Don't leak global BUILD_SHARED_LIBS into the superbuild #11800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CMiservaAMD merged 3 commits into from
Sep 16, 2026
Merged

[MIOpen] Don't leak global BUILD_SHARED_LIBS into the superbuild #11800

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fb024e
(CMCL) fix(miopen): don't leak global BUILD_SHARED_LIBS into the supe…
CMiservaAMD Sep 8, 2026
da61262
Merge branch 'develop' into users/cmiserva/almiopen-2585/miopen-super…
CMiservaAMD Sep 10, 2026
b666d14
Merge branch 'develop' into users/cmiserva/almiopen-2585/miopen-super…
CMiservaAMD Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions projects/miopen/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,16 @@ set(MIOPEN_ENABLE_SQLITE On CACHE BOOL "")
# Use SQLITE for compiled kernels, when turned off this will use raw files
set(MIOPEN_ENABLE_SQLITE_KERN_CACHE On CACHE BOOL "")

# By default build shared libraries
option(BUILD_SHARED_LIBS "Create shared libraries" ON)
# By default build shared libraries. Use a directory-scoped (non-cache) default
# rather than option()/a cache entry: a cache write to the global BUILD_SHARED_LIBS
# leaks out of MIOpen's subtree and forces sibling subprojects in a parent
# superbuild to build shared too (e.g. hipDNN's internal, un-exported
# hipdnn_backend_private, which then breaks install(EXPORT)). An explicit
# user/parent value (cache or -D) is still honored because we only set a default
# when BUILD_SHARED_LIBS is not already defined.
if(NOT DEFINED BUILD_SHARED_LIBS)
set(BUILD_SHARED_LIBS ON)
endif()

# PREPEND (rather than APPEND) so MIOpen's local cmake helpers (ClangTidy,
# ClangCheck, etc.) take precedence over any same-named modules a parent
Expand Down
Loading