Skip to content

[rocPRIM] Fix memory leaks in different unit tests #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NguyenNhuDi merged 9 commits into from
Sep 30, 2025
Merged

[rocPRIM] Fix memory leaks in different unit tests #1176

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
da31dfb
ported over fix from original branch
NguyenNhuDi Aug 12, 2025
f9cd180
switched free order
NguyenNhuDi Aug 13, 2025
67e564e
fixed device transform
NguyenNhuDi Aug 18, 2025
0c08a6a
Merge branch 'develop' into users/NguyenNhuDi/rocprim-fix-mem-leaks2
NguyenNhuDi Aug 18, 2025
76947ec
Merge branch 'develop' into users/NguyenNhuDi/rocprim-fix-mem-leaks2
NguyenNhuDi Aug 20, 2025
83a0249
Merge branch 'develop' into users/NguyenNhuDi/rocprim-fix-mem-leaks2
stanleytsang-amd Sep 3, 2025
57fb9cb
Merge branch 'develop' into users/NguyenNhuDi/rocprim-fix-mem-leaks2
NguyenNhuDi Sep 18, 2025
339f2ef
Merge branch 'develop' into users/NguyenNhuDi/rocprim-fix-mem-leaks2
NguyenNhuDi Sep 26, 2025
7525759
Merge branch 'develop' into users/NguyenNhuDi/rocprim-fix-mem-leaks2
NguyenNhuDi Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions projects/rocprim/test/hipgraph/test_hipgraph_basic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ void testStreamCapture()
ASSERT_EQ(h_data, num_launches);

// Clean up
HIP_CHECK(hipFreeAsync(d_data, stream));
HIP_CHECK(hipStreamDestroy(stream));
HIP_CHECK(hipGraphDestroy(graph));
HIP_CHECK(hipGraphExecDestroy(instance));
HIP_CHECK(hipFree(d_data));
HIP_CHECK(hipStreamDestroy(stream));
}

void testManualConstruction()
Expand Down Expand Up @@ -159,10 +159,10 @@ void testManualConstruction()
ASSERT_EQ(h_data, num_launches);

// Clean up
HIP_CHECK(hipFreeAsync(d_data, stream));
HIP_CHECK(hipStreamDestroy(stream));
HIP_CHECK(hipGraphDestroy(graph));
HIP_CHECK(hipGraphExecDestroy(instance));
HIP_CHECK(hipFree(d_data));
HIP_CHECK(hipStreamDestroy(stream));
}

void testStreamCaptureWithAtomics()
Expand Down Expand Up @@ -217,10 +217,10 @@ void testStreamCaptureWithAtomics()
ASSERT_EQ(h_data, num_launches * num_blocks * num_threads);

// Clean up
HIP_CHECK(hipStreamDestroy(stream));
HIP_CHECK(hipFreeAsync(d_data, stream));
Comment thread
amd-hsong marked this conversation as resolved.
HIP_CHECK(hipGraphDestroy(graph));
HIP_CHECK(hipGraphExecDestroy(instance));
HIP_CHECK(hipFree(d_data));
HIP_CHECK(hipStreamDestroy(stream));
}

TEST(TestHipGraphBasic, CaptureFromStream)
Expand Down
1 change: 1 addition & 0 deletions projects/rocprim/test/rocprim/test_device_merge_inplace.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ TEST(RocprimDeviceMergeInplaceTests, Basic)

h_data = d_data.load();
d_data.free_manually();
d_temp_storage.free_manually();

test_utils::assert_eq(h_data, h_expected);
}
Expand Down
3 changes: 3 additions & 0 deletions projects/rocprim/test/rocprim/test_device_transform.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,9 @@ TEST(RocprimDeviceTransformTests, UnalignedPointer)
// Check if output values are as expected
ASSERT_NO_FATAL_FAILURE(
test_utils::assert_near(output, expected, test_utils::precision<T>));

HIP_CHECK(hipFree(d_unaligned));
HIP_CHECK(hipFree(d_input));
}
}
}
Loading