Repository navigation
Revert "feat: enable shipping tensilelite-host shared" - #11736
Merged
amd-chiranjeevi merged 1 commit intoSep 7, 2026
Merged
amd-chiranjeevi merged 1 commit into
amd-chiranjeevi merged 1 commit into
Conversation
This reverts commit 7b4a377.
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11736 +/- ##
===========================================
- Coverage 70.24% 69.40% -0.84%
===========================================
Files 2809 2827 +18
Lines 462409 470119 +7710
Branches 68093 69443 +1350
===========================================
+ Hits 324788 326250 +1462
- Misses 114060 120158 +6098
- Partials 23561 23711 +150
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
TriveniTadapaneni
self-requested a review
September 7, 2026 10:08
amd-chiranjeevi
deleted the
revert-9248-users/davidd-amd/tensilelite-shared-p3-codegen
branch
September 7, 2026 10:30
Contributor
TheRock Submodule Bump ActivityNewest first
|
amd-chiranjeevi
added
the
bump-pr-revert
1 task done
davidd-amd
added a commit
that referenced
this pull request
Sep 9, 2026
This reverts commit 0d9c180.
tony-davis
added a commit
that referenced
this pull request
Sep 10, 2026
…lite-host revert (#11726) JIRA ID : AIHPBLAS-3522 Fixes #11741. ## Motivation hipBLASLt uses TensileLite to generate device libraries, and hipSPARSELt consumes that code-generation support from the staged hipBLASLt package. #9248 made `tensilelite-host` a shared library and removed hipSPARSELt's private hipBLASLt build, but the change was reverted in #11736 after the full AddressSanitizer (ASAN) build failed in ROCm/TheRock#7948. The failure occurred when hipSPARSELt's Python code-generation process imported the staged, ASAN-instrumented `rocisa` extension without first loading `libclang_rt.asan.so`. This change restores the shared TensileLite packaging and makes sanitizer runtime selection part of the exported code-generation command. Related work: #1648, #9248, #11736, ROCm/TheRock#5650, and ROCm/TheRock#7948. ## Technical Details - Restore the build and packaging changes from #9248. `tensilelite-host` is shared by default, and hipBLASLt installs the CMake code-generation module, `rocisa`, and their required runtime files as one package-owned interface. - Make hipSPARSELt consume the staged hipBLASLt package under TheRock. Standalone builds retain a source-provider fallback, and shared/static package dependencies remain explicit. - Extend `hipblaslt_codegen.cmake` to detect Clang's shared AddressSanitizer or ThreadSanitizer runtime. On Linux, generated Python commands preload that library and add its directory to the runtime search path. - Forward `HIPSPARSELT_ENABLE_ASAN` and TheRock's `ASAN`, `HOST_ASAN`, or `TSAN` selection into hipSPARSELt device-library generation. - Change the focused hipBLASLt workflow from host-only ASAN to TheRock's full `ASAN` configuration and build the `hipSPARSELt` target. This validates hipBLASLt packaging, staged consumption, and sparse device-library generation together on gfx90a. - Keep the workflow pinned to the same TheRock source-code version as Multi-Arch CI, remove the duplicate label trigger, and suppress the summary only when a newer run cancels its predecessor. No kernel algorithms or public C/C++ headers change. ## Test Plan - Reproduce the failing TheRock ASAN path by staging hipBLASLt and building hipSPARSELt against that package. - Confirm that hipSPARSELt imports the staged `rocisa` extension, validates its logic files, generates device libraries, and installs its stage. - Run the focused full-ASAN workflow and the hipBLASLt quick runtime test on gfx90a. - Observe the standard rocm-libraries automated GitHub checks on the pushed branch. ## Test Result Local validation at commit `0176b7d7da5c`, which is included in the current PR head, reproduced TheRock PR #7948's full-ASAN gfx950 build environment. The run used TheRock commit `78fb2c1c`, the original `gfx94X-dcgpu;gfx950-dcgpu` distribution set, the `gfx950-dcgpu` shard, the failing run's prerequisite artifacts, and CI image digest `sha256:cf4f6d9909056906e4a1c0bc4c245658a0af4c6a6174082a86adfa2d518b7aeb`. - Without the sanitizer environment, importing the staged `rocisa` extension reproduced `ImportError: libclang_rt.asan.so: cannot open shared object file`. With the generated preload and runtime path, the same import passed. - hipBLASLt configured, built, installed, and staged successfully. - hipSPARSELt found the staged hipBLASLt package, parsed 4,135 solutions, generated 1,966 gfx950 kernels, and completed `cmake --build build --target hipSPARSELt -- -k 0` with exit code 0. - `pre-commit run --from-ref origin/develop --to-ref HEAD` and `git diff --check` passed locally. The pushed range also passed the repository's pre-commit workflow and policy bot. The local run covered the affected gfx950 build, code-generation, and staging path. It did not run GPU runtime tests or the complete multi-architecture matrix. At the current PR head, clang-tidy, the Linux StinkyTofu job, and all four completed rocISA Linux/Windows configurations have passed. The focused gfx90a full-ASAN build, release multi-architecture math-library builds, TensileLite coverage, and Math CI are still in progress. The StinkyTofu Windows job currently reports a failure; its workflow is still running, so the failed-job log is not yet available for classification. The separate Multi-Arch CI ASAN summary passed with its Linux build skipped and is not counted as regression evidence. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. ## Risk level High (4/5) until the focused full-ASAN and multi-architecture checks pass on the expanded branch. The change restores a 34-file build and packaging update across hipBLASLt, hipSPARSELt, Origami, and StinkyTofu, and it changes installed package composition and build-time code generation. It does not modify kernel algorithms or public C/C++ headers. --------- Co-authored-by: Tony Davis <tony.davis@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts PR: #9248
Fixes issue: #11741
Test Run: https://github.com/ROCm/TheRock/actions/runs/34093684817 --> Math libs stage passed