Repository navigation
test(rocke): fall back to configured Clang for DWARF objects - #11698
Merged
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
CongMa13
reviewed
Sep 14, 2026
CongMa13
requested changes
Sep 14, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The object/DWARF round-trip tests required
llc, so a configured ROCm toolchain with Clang but nollccould select an unrelated driver and mix LLVM versions. The tests now use the first configured directory containing either driver, preferringllcover Clang within that directory. For example, Clang inROCKE_TEST_LLVM_BINtakes precedence overllcunderROCM_PATH.ISSUE ID : AICK-2167
Technical Details
ROCKE_TEST_LLVM_BIN,$ROCM_PATH/llvm/bin, then$ROCM_PATH/lib/llvm/bin.llc, then Clang, within each configured directory before proceeding to the next. Retain the existing PATH/default fallback when no configured driver is available.llcobject-generation command. The Clang command uses--target=amdgcn-amd-amdhsa,-mcpu=<arch>,-nogpulib, and the bitcode input directly.This changes test infrastructure only. Production kernel compilation continues to use in-process COMGR.
Test Plan
llc.llc; assembler and DWARF dumper also select the explicit bin.llvm/bintaking precedence overllcinlib/llvm/bin.llcwithin one directory; prefer configured Clang over unrelated PATHllc.llc/Clang command construction.Test Result
The configured-Clang object tests preserve subprograms, inline subroutines, call-site file and line information, and abstract origins. Capture-off objects contain no debug-info section.
Submission Checklist