Skip to content

feat(rocBLAS) Revert default backend to tensile for f32 and f64 on gfx950 - #11671

Merged
mpanoop merged 1 commit into
developfrom
users/kamuruga/revert_gfx950_hipblaslt_default_backend
Sep 3, 2026
Merged

mpanoop merged 1 commit into
developfrom
users/kamuruga/revert_gfx950_hipblaslt_default_backend

Conversation

@kamuruga08

@kamuruga08 kamuruga08 commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

hipBLASLt was recently made the default backend for f32 and f64 on gfx950. This Pull Request reverts the default backend for f32 and f64 back to Tensile on gfx950 due to nightly test failures.

JIRA ID : AIROCBLAS-1369

@kamuruga08
kamuruga08 requested a review from a team as a code owner September 3, 2026 17:55

@evedovelli evedovelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therock-pr-bot

therock-pr-bot Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocblas/library/src/tensile_host.cpp; no test file found
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@TorreZuk TorreZuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I guess by end of day will you merge or want me to if all passing?

@kamuruga08

Copy link
Copy Markdown
Contributor Author

Thanks, I guess by end of day will you merge or want me to if all passing?

I'll merge

@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project check has failed because the head coverage (48.31%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11671      +/-   ##
===========================================
+ Coverage    64.11%   69.59%   +5.48%     
===========================================
  Files         2826     2826              
  Lines       469837   469837              
  Branches     69389    69389              
===========================================
+ Hits        301192   326942   +25750     
+ Misses      147536   119105   -28431     
- Partials     21109    23790    +2681     
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 38.59% <ø> (ø) Carriedforward from dd749e5
TensileLite-Unit 75.55% <ø> (ø) Carriedforward from dd749e5
hipBLAS 90.62% <ø> (ø) Carriedforward from dd749e5
hipBLASLt 35.22% <ø> (ø) Carriedforward from dd749e5
hipCUB 82.68% <ø> (ø) Carriedforward from dd749e5
hipDNN 86.94% <ø> (ø) Carriedforward from dd749e5
hipFFT 42.66% <ø> (ø) Carriedforward from dd749e5
hipRAND 76.12% <ø> (ø) Carriedforward from dd749e5
hipSOLVER 68.92% <ø> (ø) Carriedforward from dd749e5
hipSPARSE 86.99% <ø> (ø) Carriedforward from dd749e5
rocBLAS 48.31% <ø> (+48.03%) ⬆️
rocFFT 51.25% <ø> (ø) Carriedforward from dd749e5
rocRAND 56.92% <ø> (ø) Carriedforward from dd749e5
rocSOLVER 76.83% <ø> (ø) Carriedforward from dd749e5
rocSPARSE 74.61% <ø> (ø) Carriedforward from dd749e5
rocThrust 91.60% <ø> (ø) Carriedforward from dd749e5

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
projects/rocblas/library/src/tensile_host.cpp 0.00% <ø> (ø)

... and 349 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mpanoop
mpanoop merged commit 8070a05 into develop Sep 3, 2026
222 of 234 checks passed
@mpanoop
mpanoop deleted the users/kamuruga/revert_gfx950_hipblaslt_default_backend branch September 3, 2026 22:15
assistant-librarian Bot pushed a commit to ROCm/rocBLAS that referenced this pull request Sep 3, 2026
feat(rocBLAS) Revert default backend to tensile for f32 and
 f64 on gfx950 (#11671)

## Motivation

hipBLASLt was recently made the default backend for f32 and f64 on
gfx950. This Pull Request reverts the default backend for f32 and f64
back to Tensile on gfx950 due to nightly test failures.

JIRA ID : AIROCBLAS-1369
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants