Skip to content

fix(ci): ignoring package builds for asan - #11668

Merged
geomin12 merged 1 commit into
developfrom
users/geomin12/multi-arch-asan-fix
Sep 3, 2026
Merged

fix(ci): ignoring package builds for asan#11668
geomin12 merged 1 commit into
developfrom
users/geomin12/multi-arch-asan-fix

Conversation

@geomin12

@geomin12 geomin12 commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

ignoring package builds for asan (particular pytorch, python, tarballs)

@geomin12 geomin12 added the ci:asan Opt-in to building ASAN label Sep 3, 2026
@github-actions github-actions Bot added github actions project: none Does not target any component labels Sep 3, 2026
@geomin12 @claude
fix(ci): disable python/pytorch/jax builds in ASAN workflow
e68f316 
Add build_python_packages, build_pytorch, and build_jax = false to the
setup job to match TheRock's multi_arch_ci_asan.yml behavior.

These builds are not supported with ASAN yet, but the ci:asan label was
attempting to run them due to missing these parameters.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@geomin12
geomin12 force-pushed the users/geomin12/multi-arch-asan-fix branch from aefeb67 to e68f316 Compare September 3, 2026 17:11
@therock-pr-bot

therock-pr-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@geomin12
geomin12 marked this pull request as ready for review September 3, 2026 17:22
@geomin12
geomin12 requested a review from a team as a code owner September 3, 2026 17:22
@geomin12 geomin12 changed the title fix(ci): call TheRock multi_arch_ci_asan.yml workflow directly fix(ci): ignoring package builds for asan Sep 3, 2026
erman-gurses
erman-gurses approved these changes Sep 3, 2026
View reviewed changes

@erman-gurses erman-gurses left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geomin12
geomin12 merged commit dc8655f into develop Sep 3, 2026
297 of 317 checks passed
@geomin12
geomin12 deleted the users/geomin12/multi-arch-asan-fix branch September 3, 2026 20:46
@assistant-librarian

assistant-librarian Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erman-gurses erman-gurses erman-gurses approved these changes
@jayhawk-commits jayhawk-commits Awaiting requested review from jayhawk-commits

Assignees

No one assigned

Labels

ci:asan Opt-in to building ASAN github actions Not ready to Review organization: ROCm project: none Does not target any component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@geomin12 @erman-gurses