Repository navigation
ci(rocke): enable rocKE engine build in multi-arch CI - #11663
Merged
BrianHarrisonAMD merged 2 commits intoSep 3, 2026
Merged
Conversation
TheRock declares HIPKERNELPROVIDER_ENABLE_ROCKE with DEFAULT_VALUE OFF, so rocm-libraries CI builds hip-kernel-provider without the rocKE engine and rocKE gets no build or test signal. Set the flag through external_repo.extra_cmake_options, which TheRock appends to the cmake configure line of each build stage for this repository's runs only. TheRock's default stays OFF for every other consumer.
github-actions
Bot
added
github actions
project: none
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
brockhargreaves-amd
self-requested a review
September 3, 2026 16:59
brockhargreaves-amd
approved these changes
Sep 3, 2026
Contributor
Author
|
Merging relevant build + tests ran successfully. |
BrianHarrisonAMD
deleted the
users/bharriso/rocke-multiarch-ci-signal
branch
September 3, 2026 19:16
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable
HIPKERNELPROVIDER_ENABLE_ROCKEfor this repository's multi-arch CI so rocKE gets build and test signal.TheRock declares the flag
OFFby default and hip-kernel-provider gatesadd_subdirectory(rocke)on it, so CI builds the provider without the engine. The single-arch workflow set the flag viatherock_matrix.py; PRs now runtherock-multi-arch-ci.yml, which passed no flag overrides.Set through
external_repo.extra_cmake_options, which TheRock appends to each build stage's cmake configure line. Scoped to this repository; TheRock's default is unchanged elsewhere.JIRA ID : AICK-2210
Risk Assessment
Risk 3. CI configuration only, no product code. Builds a component under active development on every PR that rebuilds
math-libs, so a rocKE failure blocks unrelated PRs. rocKE has not been built through TheRock's Windows toolchain before.Device / Architecture Coverage
Existing workflow families: Linux
gfx94X,gfx950(plus the develop dist set), Windowsgfx110X. Flag is scoped tohipkernelprovider; no other subproject's compile line changes.Testing Checklist
setupemits"extra_cmake_options": "-DTHEROCK_FLAG_HIPKERNELPROVIDER_ENABLE_ROCKE=ON"- Status: Passedpre-commit run --files .github/workflows/therock-multi-arch-ci.yml- Status: PassedTouching
.github/workflows/therock*triggers a full test run, so thehipkernelprovidertest job runs on this PR.Flags / Guardrails
Enables
THEROCK_FLAG_HIPKERNELPROVIDER_ENABLE_ROCKE=ONfor this workflow only; TheRock's default staysOFF.Constant by design, not derived per PR: the flag state file participates in every subproject's configure fingerprint (
cmake/therock_subproject.cmake:918) and stage reuse does not key on flag values (TheRock#3399). A conditional value would churn fingerprints acrossmath-libsand let a baseline built with the opposite value look reusable.therock-multi-arch-ci-nightly.ymland the ASAN workflows are intentionally unchanged.Technical Changes
.github/workflows/therock-multi-arch-ci.yml: addextra_cmake_optionsto theexternal_repopayload; expand the single-line JSON to a folded block.