Skip to content

Revert "perf: tune gfx12 fmha d128 bf16 tile size (#11054)" - #11657

Merged
illsilin merged 1 commit into
developfrom
users/jialuo/ck/revert_pr11054
Sep 4, 2026
Merged

illsilin merged 1 commit into
developfrom
users/jialuo/ck/revert_pr11054

Conversation

@JiaLuo-CAN

@JiaLuo-CAN JiaLuo-CAN commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

JIRA ID : SWDEV-607213

This reverts commit 2f22f22.

Motivation

CI error on compiling instance:
[2026-09-02T23:44:17.786Z] FAILED: [code=1] example/ck_tile/01_fmha/CMakeFiles/tile_fmha_fwd_instances.dir/fmha_fwd_d128_fp16_batch_b128x64x64x128x64x128_r8x1x1_r8x1x1_w16x16x16_w16x16x16_o4_qr_hpad_vr_psskddv_nlogits_nbias_nmask_lse_ndropout_nskip_nqscale_ntrload_sink_gfx12.cpp.o

[2026-09-02T23:44:17.786Z] projects/composablekernel/include/ck_tile/core/container/sequence.hpp:1253:9: error: static assertion failed due to requirement 'container_reduce(pick_sequence_elements_by_mask(ck_tile::sequence<8, 1, 2, 8>{}, ck_tile::sequence<1, 1, 0, 1>{}), ck_tile::multiplies<void, void>{}, 1) % 24 == 0': slice size can't evenly divide input sizes

Technical Details

Test Plan

Test Result

Submission Checklist

@JiaLuo-CAN
JiaLuo-CAN requested review from a team as code owners September 3, 2026 14:36
@github-actions github-actions Bot added project: composablekernel ck: attention-moe Used to tag composablekernel PRs that require approval from Attention/MOE review team. labels Sep 3, 2026
@therock-pr-bot

therock-pr-bot Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/composablekernel/example/ck_tile/01_fmha/codegen/ops/fmha_fwd.py; no test file found
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@illsilin
illsilin enabled auto-merge (squash) September 3, 2026 15:05
@illsilin
illsilin merged commit 45df3ad into develop Sep 4, 2026
158 of 167 checks passed
@illsilin
illsilin deleted the users/jialuo/ck/revert_pr11054 branch September 4, 2026 03:40
assistant-librarian Bot pushed a commit to ROCm/composable_kernel that referenced this pull request Sep 4, 2026
Revert "perf: tune gfx12 fmha d128 bf16 tile size (#11054)"
 (#11657)

This reverts commit 2f22f2282eb7051b3534ea70d7f0862e4129c85e.

## Motivation

CI error on compiling instance:
[2026-09-02T23:44:17.786Z] FAILED: [code=1]
example/ck_tile/01_fmha/CMakeFiles/tile_fmha_fwd_instances.dir/fmha_fwd_d128_fp16_batch_b128x64x64x128x64x128_r8x1x1_r8x1x1_w16x16x16_w16x16x16_o4_qr_hpad_vr_psskddv_nlogits_nbias_nmask_lse_ndropout_nskip_nqscale_ntrload_sink_gfx12.cpp.o

[2026-09-02T23:44:17.786Z]
projects/composablekernel/include/ck_tile/core/container/sequence.hpp:1253:9:
error: static assertion failed due to requirement
'container_reduce(pick_sequence_elements_by_mask(ck_tile::sequence<8, 1,
2, 8>{}, ck_tile::sequence<1, 1, 0, 1>{}), ck_tile::multiplies<void,
void>{}, 1) % 24 == 0': slice size can't evenly divide input sizes

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->

## Test Plan

<!-- Explain any relevant testing done to verify this PR. -->

## Test Result

<!-- Briefly summarize test outcomes. -->

## Submission Checklist

- [ ] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ck: attention-moe Used to tag composablekernel PRs that require approval from Attention/MOE review team. Not ready to Review organization: ROCm project: composablekernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants