Repository navigation
fix(tensilelite): disable TDMPlusLdsBuf (triple LDS buffer) pending race fix - #11654
Merged
Merged
Conversation
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
geotseng-amd
approved these changes
Sep 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #11654 +/- ##
========================================
Coverage 64.11% 64.11%
========================================
Files 2826 2826
Lines 469842 469843 +1
Branches 69389 69389
========================================
+ Hits 301195 301197 +2
Misses 147536 147536
+ Partials 21111 21110 -1
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
…ace fix Triple LDS buffer has an unresolved cross-wave read-after-write race on the rotating LDS: a fast wave overwrites a buffer a slow wave is still reading. Auto (-1) falls back to 2 buffers; explicit request (1) is rejected. Re-enable once the race is fixed.
mengzcai
force-pushed
the
users/mengzcai/mxfp8_validator
branch
from
September 3, 2026 19:20
26f4d3c to
90577b2
Compare
boringmorning
approved these changes
Sep 4, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : AIHPBLAS-4459
Motivation
In the ticket : AIHPBLAS-4459. They saw the kernel failed hipblaslt-bench verification run.
Root cause: Triple LDS buffer has an unresolved cross-wave read-after-write race on the rotating LDS
This is a temporary safety gate (marked TEMP in code); the proper fix will restore
triple buffering with the race resolved, then revert this reject.
Technical Details
A fast wave overwrites a buffer a slow wave is still reading. Auto (TDMPlusLdsBuf=-1) falls back to 2 buffers; explicit request (TDMPlusLdsBuf=1) is rejected. Re-enable once the race is fixed.
Test Plan
(triple=-1 falls back to double, no cross-wave race)
Test Result
Testing
Submission Checklist