Skip to content

Add build and install rpath for hipfft-test and rocfft-test for finding libomp.so #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malcolmroberts merged 1 commit into from
Aug 13, 2025
Merged

Add build and install rpath for hipfft-test and rocfft-test for finding libomp.so #1164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions projects/hipfft/clients/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ if( BUILD_CLIENTS_TESTS_OPENMP AND NOT BUILD_WITH_LIB STREQUAL "CUDA" )
if( NOT OPENMP_FOUND OR NOT DEFINED ${openmp_LIB_DIR} )
# Fall-back to module mode.
find_package( OpenMP REQUIRED )
set( BUILD_RPATH "${HIP_CLANG_ROOT}/lib" )
set( INSTALL_RPATH "$ORIGIN/../llvm/lib" )
else()
set( BUILD_RPATH "${HIP_CLANG_ROOT}/${openmp_LIB_DIR}" )
set( INSTALL_RPATH "$ORIGIN/../llvm/${openmp_LIB_DIR}" )

endif()
endif()

Expand All @@ -126,6 +132,15 @@ foreach( target ${TEST_TARGETS} )
CXX_STANDARD_REQUIRED ON
)

if( BUILD_CLIENTS_TESTS_OPENMP )
set_target_properties( ${TEST_TARGETS} PROPERTIES
BUILD_RPATH "${BUILD_RPATH}"
)
set_target_properties( ${TEST_TARGETS} PROPERTIES
INSTALL_RPATH "${INSTALL_RPATH}"
)
endif()

if( BUILD_WITH_LIB STREQUAL "ROCM" )
target_compile_options( ${target} PRIVATE ${WARNING_FLAGS} )
target_link_libraries( ${target}
Expand Down
25 changes: 24 additions & 1 deletion projects/rocfft/clients/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,10 +196,24 @@ if( BUILD_CLIENTS_TESTS_OPENMP )
if( NOT OPENMP_FOUND OR NOT DEFINED ${openmp_LIB_DIR} )
# Fall-back to module mode.
find_package( OpenMP REQUIRED )
set( BUILD_RPATH "${HIP_CLANG_ROOT}/lib" )
set( INSTALL_RPATH "$ORIGIN/../llvm/lib" )
else()
set( BUILD_RPATH "${HIP_CLANG_ROOT}/${openmp_LIB_DIR}" )
set( INSTALL_RPATH "$ORIGIN/../llvm/${openmp_LIB_DIR}" )
endif()
list( APPEND rocfft-test_link_libs OpenMP::OpenMP_CXX )
list( APPEND rocfft-test_link_libs OpenMP::OpenMP_CXX )

set_target_properties( rocfft-test PROPERTIES
BUILD_RPATH "{$BUILD_RPATH}"
)
set_target_properties( rocfft-test PROPERTIES
INSTALL_RPATH "${INSTALL_RPATH}"
)
endif()



include( ../cmake/build-gtest.cmake )

if( BUILD_GTEST OR NOT GTEST_FOUND )
Expand Down Expand Up @@ -334,6 +348,15 @@ if( ROCFFT_MPI_ENABLE )
# normal and dynamic-loading MPI worker processes
foreach(worker rocfft_mpi_worker dyna_rocfft_mpi_worker)
add_executable( ${worker} rocfft_mpi_worker.cpp )

if( BUILD_CLIENTS_TESTS_OPENMP )
set_target_properties( ${worker} PROPERTIES
BUILD_RPATH "${BUILD_RPATH}"
)
set_target_properties( ${worker} PROPERTIES
INSTALL_RPATH "${INSTALL_RPATH}"
)
endif()
if( BUILD_FFTW OR NOT FFTW_FOUND )
add_dependencies( ${worker} fftw_double fftw_single )
endif()
Expand Down