Skip to content

[ROCm][Windows] Add missing MIOPEN_INTERNALS_EXPORT to convolution ocl functions #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrianHarrisonAMD merged 3 commits into from
Aug 13, 2025
Merged

[ROCm][Windows] Add missing MIOPEN_INTERNALS_EXPORT to convolution ocl functions #1158

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
533c660
Merge branch 'develop' into export_symbols_in_conv_ocl
BrianHarrisonAMD Aug 12, 2025
63fe3ef
add missing MIOPEN_INTERNALS_EXPORT in convolution ocl
tvukovic-amd Aug 12, 2025
a8e93a0
Merge branch 'develop' into export_symbols_in_conv_ocl
tvukovic-amd Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions projects/miopen/src/ocl/convolutionocl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ static void ShrinkToFind10Results(std::vector<Solution>& found)
found = std::move(out);
}

MIOPEN_INTERNALS_EXPORT
std::vector<solver::ConvSolution>
GetConvSolutions(const ExecutionContext& ctx,
const conv::ProblemDescription& problem,
Expand All @@ -274,6 +275,7 @@ GetConvSolutions(const ExecutionContext& ctx,
return conv_sols;
}

MIOPEN_INTERNALS_EXPORT
std::vector<Solution> EvaluateConvSolutions(const ExecutionContext& ctx,
const conv::ProblemDescription& problem,
const AnyInvokeParams& invoke_ctx,
Expand Down Expand Up @@ -319,6 +321,7 @@ std::vector<Solution> EvaluateConvSolutions(const ExecutionContext& ctx,
return eval_sols;
}

MIOPEN_INTERNALS_EXPORT
bool HasGoodSolution(const std::vector<miopenConvSolution_t> solutions,
const std::vector<Solution> eval_sols,
const bool model_result)
Expand Down