Skip to content

Add toggle for Python Packages, PyTorch, JAX, and Native Linux Packages - #11439

Merged
jayhawk-commits merged 2 commits into
developfrom
users/erman-gurses/add-toggles
Aug 29, 2026
Merged

jayhawk-commits merged 2 commits into
developfrom
users/erman-gurses/add-toggles

Conversation

@erman-gurses

Copy link
Copy Markdown
Contributor

Issue: ROCm/TheRock#3343

Add toggle for Python packages, PyTorch, JAX, native Linux packages, and Python package tests are not run by default.

@erman-gurses
erman-gurses requested a review from a team as a code owner August 28, 2026 20:22
@github-actions github-actions Bot added github actions project: none Does not target any component labels Aug 28, 2026
@therock-pr-bot

therock-pr-bot Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@erman-gurses

erman-gurses commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor Author

Multi-Arch CI Package-Build and Stage-Reuse Validation

PR Expected Behavior Observed Behavior
rocPRIM validation PR math-libs rebuilds and rocPRIM-related tests run. Unaffected stages reuse baseline artifacts. Python package, PyTorch, JAX, and native Linux packaging builds remain disabled. Pending — update after the Multi-Arch CI run completes.
RPP validation PR cv-libs rebuilds and RPP-related tests run. Unaffected stages reuse baseline artifacts. Python package, PyTorch, JAX, and native Linux packaging builds remain disabled. Pending — verify whether cv-libs rebuilds or is reused because it is currently included in prebuilt_stages.
MIOpen validation PR The math-libs stage, which contains the ml-libs artifact group, rebuilds and MIOpen-related tests run. Unaffected stages reuse baseline artifacts. Python package, PyTorch, JAX, and native Linux packaging builds remain disabled. Pending — update after the Multi-Arch CI run completes.

@jayhawk-commits jayhawk-commits left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CI results show build stages being re-used and skipped as expected.

The initial set of attempts with extra PRs to verify test behaviour is bad because the test detection logic flags workflow changes as a reason to test all. Next step is to merge this and re-route those validation PR's runs.

@jayhawk-commits
jayhawk-commits merged commit 1d9975b into develop Aug 29, 2026
446 of 466 checks passed
@jayhawk-commits
jayhawk-commits deleted the users/erman-gurses/add-toggles branch August 29, 2026 03:03
@jayhawk-commits

jayhawk-commits commented Aug 29, 2026 •

Copy link
Copy Markdown
Collaborator

Multi-Arch CI Changed-Project Validation Coverage

Updated after checking the latest TheRock Multi-Arch CI runs visible on each validation PR. These PRs are temporary no-op changes intended to exercise changed-project detection for one subtree at a time.

Common observation across the linked runs: Python package/test jobs, PyTorch, JAX, and native DEB/RPM package/install jobs are skipped by default as intended.

PR Subtree Multi-Arch run Observed build behavior Observed test behavior Notes
#11444 projects/rocprim run 33230454834 math-libs rebuilt; unrelated stage families skipped/reused rocPRIM dependency set ran: rocprim, hipcub, rocthrust, rocsparse, rocsolver, rocalution Matches intended changed-project behavior
#11448 projects/rpp run 33230461586 Current linked run does not show desired RPP-specific behavior: math-libs rebuilt and cv-libs skipped Broad test set ran, including rpp, HIP/runtime, math, debug, profiler, media, and comm tests; the run also has failures in unrelated jobs Demonstrates the projects/rpp repos-config gap; covered by #11459, which is still open
#11449 projects/miopen run 33230465167 math-libs rebuilt; unrelated stage families skipped/reused miopen and miopenprovider tests ran Matches intended changed-project behavior
#11460 projects/hipblaslt run 33233292479 math-libs rebuilt; unrelated stage families skipped/reused hipblaslt, hipblasltprovider, hipsparselt, miopen, and rocblas tests ran Matches intended changed-project behavior
#11461 projects/hipfft run 33233293381 math-libs rebuilt; unrelated stage families skipped/reused hipfft tests ran Matches intended changed-project behavior
#11462 projects/hipdnn run 33233296397 math-libs rebuilt; unrelated stage families skipped/reused hipdnn, hipblasltprovider, hipkernelprovider, and miopenprovider tests ran Matches intended changed-project behavior
#11463 projects/rocblas run 33233764627 math-libs rebuilt; unrelated stage families skipped/reused rocblas, hipblas, hipsolver, miopen, rocalution, rocsolver, rocsparse, and rocwmma tests ran Matches intended changed-project behavior
#11464 projects/rocsparse run 33233767232 math-libs rebuilt; unrelated stage families skipped/reused rocsparse, hipsparse, hipsparselt, hipsolver, rocblas, rocprim, rocsolver, and rocalution tests ran Matches intended changed-project behavior
#11465 projects/rocsolver run 33233770822 math-libs rebuilt; unrelated stage families skipped/reused rocsolver, hipsolver, and hipblas tests ran Matches intended changed-project behavior
#11466 projects/rocrand run 33233773614 math-libs rebuilt; unrelated stage families skipped/reused rocrand, hiprand, rocprim, rocthrust, rocfft, hipfft, miopen, and rocalution tests ran Matches intended changed-project behavior
#11467 projects/hiptensor run 33233776042 math-libs rebuilt; unrelated stage families skipped/reused hiptensor tests ran Matches intended changed-project behavior
#11468 shared/rocroller run 33233779105 math-libs rebuilt; unrelated stage families skipped/reused Only sanity tests ran Exposes test-selection mapping gap for shared/rocroller; expected to be fixed by ROCm/TheRock#7741
#11469 dnn-providers/miopen-provider run 33233781647 math-libs rebuilt; unrelated stage families skipped/reused Only sanity tests ran Exposes test-selection mapping gap for dnn-providers/miopen-provider; expected to be fixed by ROCm/TheRock#7741

Local verification:

  • Confirmed the additional temporary PRs each have exactly one no-op changed file under the intended subtree.
  • Ran TheRock's configure_external_repo_ci.py against the PR base/head SHAs for the validation set. The temporary PRs emit the intended changed_projects value with run_all_tests=false and skip_tests=false, except for known repos-config coverage gaps such as projects/rpp before #11459.
  • The observed build-stage behavior is generally correct. The remaining gaps are in test dependency selection for external subtree names that do not match TheRock graph keys, which is the scope of ROCm/TheRock#7741.

@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

@jayhawk-commits

jayhawk-commits commented Aug 31, 2026 •

Copy link
Copy Markdown
Collaborator

Multi-Arch CI Revalidation After TheRock and rocm-libraries Fixes

Added ci:multi-arch to the temporary validation PRs and updated each branch from develop so the runs include the merged rocm-libraries workflow changes and the latest pinned TheRock workflow fixes.

All fresh TheRock Multi-Arch CI runs completed. Common observed behavior across the runs:

  • ci:multi-arch successfully enabled the workflow.
  • Python packages/tests, PyTorch, JAX, DEB/RPM builds, and DEB/RPM install tests were skipped by default.
  • The TheRock mapping fixes are effective for shared/rocroller and dnn-providers/miopen-provider test selection.
  • Most non-target stages were copied from prebuilt baseline or skipped.
  • Observed rebuilt stages were generally compiler-runtime + math-libs.
PR Subtree Run Result Expected Observed
#11444 projects/rocprim 33442874464 Success math-libs rebuild; rocPRIM dependency tests Matches. Built compiler-runtime, math-libs. Ran rocprim, hipcub, rocthrust, rocsparse, rocsolver, rocalution.
#11448 projects/rpp 33442875036 Success cv-libs rebuild; RPP tests Partial. Ran rpp tests, but build still rebuilt compiler-runtime, math-libs; cv-libs did not rebuild.
#11449 projects/miopen 33442874137 Success ML/math rebuild; MIOpen tests Matches. Built compiler-runtime, math-libs. Ran miopen, miopenprovider.
#11460 projects/hipblaslt 33442901028 Success math-libs rebuild; hipBLASLt dependency tests Matches. Ran hipblaslt, hipblasltprovider, hipsparselt, miopen, rocblas.
#11461 projects/hipfft 33442899718 Success math-libs rebuild; hipFFT tests Matches. Ran hipfft.
#11462 projects/hipdnn 33442902772 Success ML-related rebuild; hipDNN/provider tests Matches. Ran hipdnn, hipblasltprovider, hipkernelprovider, miopenprovider.
#11463 projects/rocblas 33442900728 Failure math-libs rebuild; rocBLAS dependency tests Selection matches. Ran rocblas, hipblas, hipsolver, miopen, rocalution, rocsolver, rocsparse, rocwmma. Failure does not look like under-selection.
#11464 projects/rocsparse 33442932810 Failure math-libs rebuild; rocSPARSE dependency tests Selection matches. Ran rocsparse, hipsparse, hipsparselt, hipsolver, rocblas, rocprim, rocsolver, rocalution. Failure does not look like under-selection.
#11465 projects/rocsolver 33442930337 Success math-libs rebuild; rocSOLVER dependency tests Matches. Ran rocsolver, hipsolver, hipblas.
#11466 projects/rocrand 33442931394 Success math-libs rebuild; rocRAND dependency tests Matches. Ran rocrand, hiprand, rocprim, rocthrust, rocfft, hipfft, miopen, rocalution.
#11467 projects/hiptensor 33442932762 Success math-libs rebuild; hipTensor tests Matches. Ran hiptensor.
#11468 shared/rocroller 33442931732 Success TheRock mapping fix should select rocRoller tests Matches. Ran rocroller plus dependencies hipblaslt, hipdnn, miopen.
#11469 dnn-providers/miopen-provider 33442952713 Success TheRock mapping fix should select MIOpen provider tests Matches. Ran miopenprovider.

Bottom line: test selection now looks good, including the TheRock mapping fixes for shared/rocroller and dnn-providers/miopen-provider. The remaining suspicious gap is RPP build coverage: tests run, but cv-libs is still not rebuilt in the observed run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants