Skip to content

chore(tensilelite): remove obsolete benchmark client module - #11375

Merged
newling merged 1 commit into
ROCm:developfrom
newling:users/jnewling/tensilelite-remove-benchmark-library-client
Sep 1, 2026
Merged

newling merged 1 commit into
ROCm:developfrom
newling:users/jnewling/tensilelite-remove-benchmark-library-client

Conversation

@newling

@newling newling commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Related: #10605

TensileLite includes Python tools for generating and benchmarking GPU kernels. Those tools are normally exposed through a supported command or used by the library-generation workflow, which gives users a practical way to discover and rely on them.

TensileBenchmarkLibraryClient no longer fits that model. Current packaging does not provide a command for it, production code does not import it, and the documentation does not describe a workflow that uses it. The module also predates the supported Python 3 environment and fails in its basic statistics path. Its remaining tests record that failure rather than protect working behavior.

This change removes the module, its dedicated tests, and the associated coverage record. It does not affect kernel generation, runtime library selection, device code, or the public hipBLASLt interface. The remaining unit suite still collects, the coverage checks pass, and automated GitHub checks are pending.

The compatibility risk is limited to an external script importing this undocumented module directly.

@therock-pr-bot

therock-pr-bot Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@codecov

codecov Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11375      +/-   ##
===========================================
+ Coverage    69.24%   69.25%   +0.01%     
===========================================
  Files         2826     2820       -6     
  Lines       468873   467954     -919     
  Branches     69223    69047     -176     
===========================================
- Hits        324662   324059     -603     
+ Misses      120519   120321     -198     
+ Partials     23692    23574     -118     
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 38.93% <ø> (ø)
TensileLite-Unit 75.57% <ø> (+0.04%) ⬆️
hipBLAS 90.62% <ø> (ø) Carriedforward from 5139a61
hipBLASLt 35.25% <ø> (+<0.01%) ⬆️
hipCUB 82.68% <ø> (ø) Carriedforward from 5139a61
hipDNN 86.95% <ø> (ø) Carriedforward from 5139a61
hipFFT 43.67% <ø> (ø) Carriedforward from 5139a61
hipRAND 76.12% <ø> (ø) Carriedforward from 5139a61
hipSOLVER 68.92% <ø> (ø) Carriedforward from 5139a61
hipSPARSE 86.99% <ø> (ø) Carriedforward from 5139a61
rocBLAS 48.29% <ø> (ø) Carriedforward from 5139a61
rocFFT 45.91% <ø> (ø) Carriedforward from 5139a61
rocRAND 56.91% <ø> (ø) Carriedforward from 5139a61
rocSOLVER 76.83% <ø> (ø) Carriedforward from 5139a61
rocSPARSE 74.61% <ø> (+0.08%) ⬆️ Carriedforward from 5139a61
rocThrust 91.60% <ø> (ø) Carriedforward from 5139a61

*This pull request uses carry forward flags. Click here to find out more.
see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@newling
newling marked this pull request as ready for review August 28, 2026 19:58
@newling
newling requested a review from a team as a code owner August 28, 2026 19:58
@newling
newling force-pushed the users/jnewling/tensilelite-remove-benchmark-library-client branch from 22b659d to e66e4dd Compare August 31, 2026 21:10
@newling
newling force-pushed the users/jnewling/tensilelite-remove-benchmark-library-client branch from e66e4dd to 99689c3 Compare September 1, 2026 16:13
@newling
newling merged commit 7e1b7ae into ROCm:develop Sep 1, 2026
80 of 84 checks passed
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants