Repository navigation
Attention_dense lds_k_group_pad Lever - #11222
Merged
dlangbe merged 1 commit intoAug 26, 2026
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
dlangbe
force-pushed
the
users/dlangbe/rocke-attention_dense-lds_k_group_pad
branch
from
August 24, 2026 20:05
27a80db to
17135ad
Compare
AnaghaRaoAMD
approved these changes
Aug 25, 2026
dlangbe
deleted the
users/dlangbe/rocke-attention_dense-lds_k_group_pad
branch
August 26, 2026 19:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : AICK-1895
Motivation
lds_k_group_padwas added toAttentionDenseSpecin PR #10102 with a fixeddefault of 8. That PR committed to a follow-up sweep over the full pad space to
confirm the default and record whether any shape benefits from a different value.
This PR closes that follow-up by documenting the sweep methodology, results, and
decision in-repo, and making the knob visible in the runbook's knob catalog.
Technical Details
Three documentation edits:
library/builders/gfx950/attention/prefill/README.md— there are now three (
block_n,waves_per_eu,lds_k_group_pad).## Tuning — lds_k_group_padsection documenting:causal/swa/varlen/persistent × S ∈ {2048, 4096, 8192} (840 configs,
all correctness-passed).
the 4-lanes-per-bank floor, and what it would take to separate them.
without an ABBA repeat; pad=16 has an unacceptable regression on a bn=128
sliding-window shape that makes it unsafe as a global or shape-conditioned
default.
smem_load_vNstamps align 16unconditionally;
__post_init__enforces it).platform/dsl_docs/optimization/optimization_runbook.md§12.1.Flds_k_group_padknob-catalog row, sibling to the existinglds_k_padand
lds_layoutrows. Points to the gfx950 README for the full decisionrecord. Makes the knob visible to the Step 0 exhaustive lever sweep.
library/builders/gfx942/attention/prefill/README.mdthe shared
AttentionDenseSpec.lds_k_group_padfield and inherits default 8,with a cross-reference to the gfx950 sweep.
Per
platform/AGENTS.md§Compliance, absolute TFLOPS figures and per-leverdeltas are kept on the protected results page only; the in-repo docs contain
methodology, axes, decision, and qualitative direction.
Test Plan
corrected to reflect three knobs.
LDS-layout knobs.
relationship and points to the canonical decision record.
Test Result
No functional changes. All existing parity and byte-identity gates are unaffected.
Submission Checklist