Skip to content

Fix for LDSTranspose 1LDSBuffer=0 #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnemanich merged 3 commits into from
Aug 8, 2025
Merged

Fix for LDSTranspose 1LDSBuffer=0 #1109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb856bc
Fix for LDSTranspose 1LDSBuffer=0
adityalj Aug 7, 2025
109a5b0
Added test case for LDS transpose with double buffering and LDS>64K
adityalj Aug 7, 2025
49b5273
Merge branch 'develop' into fix_ldsTr
bnemanich Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/hipblaslt/tensilelite/Tensile/Components/LocalRead.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ def __call__(self, writer, kernel, bufferIdx, iui, epsi, tP):
numberMTilesPerWave = kernel["MIWaveTile"][tile01]
highBits = 0
for tIdx in range(0, numberMTilesPerWave):
offset_val = (tP["localReadOffset"]+MIWaveGroupShape[tile01]*tIdx) * tP["bpeDS"]
offset_val = (tP["localReadOffset"]+MIWaveGroupShape[tile01]*tIdx) * tP["bpeDS"] + tP["localReadSwapByteOffset"]
if (kernel["LdsBlockSizePerPad%s"%tc] != 0) and (kernel["LdsPad%s"%tc] != 0):
offset_val = offset_val + (offset_val // kernel["LdsBlockSizePerPad%s"%tc]) * kernel["LdsPad%s"%tc] * tP["bpeDS"]
offset, srcAddr = self.cal_offset_srcAddr(maxLDSConstOffset, tc, offset_val)
Expand Down
45 changes: 45 additions & 0 deletions projects/hipblaslt/tensilelite/Tensile/Tests/common/gemm/gfx950/lds_tr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,6 +786,51 @@ BenchmarkProblems:
- Exact: [512, 512, 1, 1088]
- Exact: [519, 519, 1, 1120]
- Exact: [2053, 2053, 1, 2053]
########################################
# NN - standard HHS Test LDS > 64K Double Buffer
########################################
-
- # ProblemType
OperationType: GEMM
DataType: h
DestDataType: h
ComputeDataType: s
HighPrecisionAccumulate: True
TransposeA: 0
TransposeB: 0
UseBeta: True
UseBias: 0 # 1
Batched: True
Activation: False
ActivationHPA: False
- # BenchmarkProblemSizeGroup - Standard - All problem
InitialSolutionParameters:
BenchmarkCommonParameters:
- KernelLanguage: ["Assembly"]
ForkParameters:
- MatrixInstruction:
- [32, 32, 16, 1, 1, 5, 3, 2, 2 ]
- PrefetchGlobalRead: [1]
- PrefetchLocalRead: [1]
- ClusterLocalRead: [0]
- DepthU: [32]
- LocalReadVectorWidth: [8]
- VectorWidthA: [1]
- ScheduleIterAlg: [3]
- TransposeLDS: [1] #0,1
- LdsBlockSizePerPadA: [-1]
- LdsBlockSizePerPadB: [-1]
- LdsPadA: [-1]
- LdsPadB: [-1]
- StaggerU: [0]
- StaggerUStride: [64]
- 1LDSBuffer: [0]
- LDSTrInst: [1]
- SourceSwap: [1]
BenchmarkJoinParameters:
BenchmarkFinalParameters:
- ProblemSizes:
- Exact: [4096, 4096, 1, 8192]

########################################
# HSS - Test LDS > 64K
Expand Down
Loading