Skip to content

fix(tensilelite): handle single-wave TDM kernel M/N edge - #11064

Merged
jichangjichang merged 1 commit into
ROCm:developfrom
Serge45:users/sergelu/tdm-single-wave-mn-edge
Sep 3, 2026
Merged

jichangjichang merged 1 commit into
ROCm:developfrom
Serge45:users/sergelu/tdm-single-wave-mn-edge

Conversation

@Serge45

@Serge45 Serge45 commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

JIRA ID : AIHPBLAS-4424

Motivation

For single-wave TDM kernel, the M/N edge handling is missing.

Technical Details

Properly calculate the edge size for single-wave TDM kernel.

Test Plan

tdm_gfx1250.yaml passed.(it includes single-wave+edge sizes)

Test Result

tdm_gfx1250.yaml passed

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/hipblaslt/tensilelite/Tensile/KernelWriterAssembly.py; no test file found
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@codecov

codecov Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...blaslt/tensilelite/Tensile/KernelWriterAssembly.py 57.14% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11064      +/-   ##
===========================================
- Coverage    63.78%   63.75%   -0.03%     
===========================================
  Files         2825     2825              
  Lines       469128   469772     +644     
  Branches     69270    69384     +114     
===========================================
+ Hits        299226   299480     +254     
- Misses      148858   149236     +378     
- Partials     21044    21056      +12     
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 38.61% <ø> (-0.46%) ⬇️
TensileLite-Unit 75.61% <57.14%> (+0.08%) ⬆️
hipBLAS 90.62% <ø> (ø) Carriedforward from 56711fb
hipBLASLt 35.22% <ø> (ø)
hipCUB 82.68% <ø> (ø) Carriedforward from 56711fb
hipDNN 86.95% <ø> (ø) Carriedforward from 56711fb
hipFFT 43.67% <ø> (ø) Carriedforward from 56711fb
hipRAND 76.12% <ø> (ø) Carriedforward from 56711fb
hipSOLVER 68.92% <ø> (ø) Carriedforward from 56711fb
hipSPARSE 86.99% <ø> (ø) Carriedforward from 56711fb
rocBLAS 0.28% <ø> (ø) Carriedforward from 56711fb
rocFFT 45.91% <ø> (ø) Carriedforward from 56711fb
rocRAND 56.91% <ø> (ø) Carriedforward from 56711fb
rocSOLVER 76.83% <ø> (ø) Carriedforward from 56711fb
rocSPARSE 74.61% <ø> (ø) Carriedforward from 56711fb
rocThrust 91.60% <ø> (ø) Carriedforward from 56711fb

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...blaslt/tensilelite/Tensile/KernelWriterAssembly.py 70.07% <57.14%> (+0.02%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Serge45
Serge45 requested a review from jichangjichang August 21, 2026 04:18
@Serge45
Serge45 force-pushed the users/sergelu/tdm-single-wave-mn-edge branch from c44099a to 4fbd2a7 Compare September 3, 2026 04:00
@Serge45
Serge45 enabled auto-merge (squash) September 3, 2026 05:57
@jichangjichang

Copy link
Copy Markdown
Contributor

this is only for gfx1250 and tox are all passed.

@jichangjichang
jichangjichang merged commit 271344a into ROCm:develop Sep 3, 2026
147 of 158 checks passed
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants