Repository navigation
(fix) rocThrust - Fix fetchdeps function in CMake - #10978
Merged
stanleytsang-amd merged 1 commit intoAug 19, 2026
Merged
stanleytsang-amd merged 1 commit into
stanleytsang-amd merged 1 commit into
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10978 +/- ##
===========================================
+ Coverage 69.36% 69.43% +0.07%
===========================================
Files 2778 2808 +30
Lines 458114 460060 +1946
Branches 67566 67875 +309
===========================================
+ Hits 317756 319429 +1673
- Misses 117218 117455 +237
- Partials 23140 23176 +36
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
|
stanleytsang-amd
deleted the
users/stanleytsang-amd/thrust-fetchdeps-fix-rocrand
branch
August 19, 2026 14:42
1 task
marbre
added a commit
that referenced
this pull request
Aug 19, 2026
… 10.0 (#10991) This PR cherry picks #10978 to the 10.0 release branch. ## Motivation Further investigation revealed some bugs in the fetch_dep call that is used to get rocPRIM and/or rocRAND as dependencies. Hardcoded references to rocPRIM were used, which obviously breaks when trying to fetch rocRAND. This was causing rocRAND installs not being found, specifically in [TheRock CI for ROCm 10](https://github.com/ROCm/TheRock/actions/runs/32192515118/job/95906621978?pr=7330), which in turn triggered rocThrust to download rocRAND, which in turn triggers #10967 and #10956, and also other behaviour that will soon be undesired, specifically the packaging of duplicate files in separate library packages. Unfortunately for this last behaviour, the fix is beyond the scope of ROCm 10. ## Technical Details Fix the `fetch_dep` function in cmake/Dependencies.cmake to properly handle both rocPRIM and rocRAND. ## Test Plan Run ROCm/TheRock#7475 in advance to see if TheRock CI passes completely. ## Test Result While it is still running at the time of writing, the Validate Artifact Structure job passed, which is what this PR aims to fix. The windows jobs seem stuck but everything else passes. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. JIRA ID: ROCM-29174 --------- Co-authored-by: Marius Brehler <marius.brehler@amd.com>
stanleytsang-amd
added a commit
that referenced
this pull request
Sep 18, 2026
## Motivation Further investigation revealed some bugs in the fetch_dep call that is used to get rocPRIM and/or rocRAND as dependencies. Hardcoded references to rocPRIM were used, which obviously breaks when trying to fetch rocRAND. This was causing rocRAND installs not being found, specifically in [TheRock CI for ROCm 10](https://github.com/ROCm/TheRock/actions/runs/32192515118/job/95906621978?pr=7330), which in turn triggered rocThrust to download rocRAND, which in turn triggers #10967 and #10956, and also other behaviour that will soon be undesired, specifically the packaging of duplicate files in separate library packages. Unfortunately for this last behaviour, the fix is beyond the scope of ROCm 10. ## Technical Details Fix the `fetch_dep` function in cmake/Dependencies.cmake to properly handle both rocPRIM and rocRAND. ## Test Plan Run ROCm/TheRock#7475 in advance to see if TheRock CI passes completely. ## Test Result While it is still running at the time of writing, the Validate Artifact Structure job passed, which is what this PR aims to fix. I will check in the morning on the status. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
illsilin
pushed a commit
to igorluppi/rocm-libraries
that referenced
this pull request
Oct 1, 2026
## Motivation Further investigation revealed some bugs in the fetch_dep call that is used to get rocPRIM and/or rocRAND as dependencies. Hardcoded references to rocPRIM were used, which obviously breaks when trying to fetch rocRAND. This was causing rocRAND installs not being found, specifically in [TheRock CI for ROCm 10](https://github.com/ROCm/TheRock/actions/runs/32192515118/job/95906621978?pr=7330), which in turn triggered rocThrust to download rocRAND, which in turn triggers ROCm#10967 and ROCm#10956, and also other behaviour that will soon be undesired, specifically the packaging of duplicate files in separate library packages. Unfortunately for this last behaviour, the fix is beyond the scope of ROCm 10. ## Technical Details Fix the `fetch_dep` function in cmake/Dependencies.cmake to properly handle both rocPRIM and rocRAND. ## Test Plan Run ROCm/TheRock#7475 in advance to see if TheRock CI passes completely. ## Test Result While it is still running at the time of writing, the Validate Artifact Structure job passed, which is what this PR aims to fix. I will check in the morning on the status. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Further investigation revealed some bugs in the fetch_dep call that is used to get rocPRIM and/or rocRAND as dependencies. Hardcoded references to rocPRIM were used, which obviously breaks when trying to fetch rocRAND. This was causing rocRAND installs not being found, specifically in TheRock CI for ROCm 10, which in turn triggered rocThrust to download rocRAND, which in turn triggers #10967 and #10956, and also other behaviour that will soon be undesired, specifically the packaging of duplicate files in separate library packages. Unfortunately for this last behaviour, the fix is beyond the scope of ROCm 10.
Technical Details
Fix the
fetch_depfunction in cmake/Dependencies.cmake to properly handle both rocPRIM and rocRAND.Test Plan
Run ROCm/TheRock#7475 in advance to see if TheRock CI passes completely.
Test Result
While it is still running at the time of writing, the Validate Artifact Structure job passed, which is what this PR aims to fix. I will check in the morning on the status.
Submission Checklist