Repository navigation
fix(miopen): clean stale gfx950 grouped-wrw dbsync entries, re-enable dbsync (rocm-libraries#2266) - #10900
Closed
JonathanLichtnerAMD wants to merge 1 commit into
Closed
fix(miopen): clean stale gfx950 grouped-wrw dbsync entries, re-enable dbsync (rocm-libraries#2266)#10900JonathanLichtnerAMD wants to merge 1 commit into
JonathanLichtnerAMD wants to merge 1 commit into
Conversation
…#2266) StaticFDBSync[gfx950] has failed on 2 stale ConvHipImplicitGemmGroupWrwXdlops perf-config entries in the gfx950 SystemDB (fdb-keys 128-7-7-1x1-1888-7-7-128-... and 240-14-14-3x3-240-14-14-16-...) every time it's been run, on both the old container CK and fresh source-built CK -- genuinely stale entries, not a CK-version artifact. Same class of issue PR #10043 fixed for gfx942, but no gfx950 hardware was available to run the usual real-hardware MIOPEN_DBSYNC_CLEAN pass. Fixed via the rocjitsu GPU-free dbsync CI (ALMIOPEN-1779): fetched a source-CK TheRock gfx950 artifact, ran StaticFDBSync[gfx950] under rocjitsu with MIOPEN_DEVICE_ARCH=gfx950 MIOPEN_DBSYNC_CLEAN=1 (rewrites the find/perf DB files in place, stripping only entries that fail applicability/perf-config validation), then verified a fresh process re-reading the cleaned files now passes with 0 failures. Diffed the cleaned files against the committed versions: exactly the 2 known-bad fdb-keys changed, with only the ConvHipImplicitGemmGroupWrwXdlops entry removed from each -- every other solver's entry for those keys is untouched. Re-enables gfx950 dbsync in TheRock CI (test/therock/test_miopen.py), removing the TODO(rocm-libraries#2266) exclusion -- dbsync now runs and passes for gfx950 like every other family. ALMIOPEN-1779 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Contributor
Author
JonathanLichtnerAMD
deleted the
users/jlichtne/almiopen-1779-gfx950-dbsync-fix
branch
August 17, 2026 22:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: ALMIOPEN-1779 · Closes: rocm-libraries#2266
Summary
StaticFDBSync[gfx950]has failed on 2 staleConvHipImplicitGemmGroupWrwXdlopsperf-config entries in the gfx950 SystemDB every time it's been run — under the original frozen container CK and a fresh source-built CK alike, so these are genuinely stale entries, not a CK-version artifact:Same class of issue PR #10043 fixed for gfx942 — but no gfx950 hardware was available here to run the usual real-hardware
MIOPEN_DBSYNC_CLEANpass.How this was fixed (GPU-free, via the rocjitsu dbsync CI from ALMIOPEN-1779)
StaticFDBSync[gfx950]under the rocjitsu KMD interposer (MIOPEN_DEVICE_ARCH=gfx950) withMIOPEN_DBSYNC_CLEAN=1— this rewrites the find-db/perf-db files in place, removing only entries that fail applicability/perf-config validation (db_sync.cpp:847-859→RamDb::Remove()).[PASSED] 1 test, 0 failures.ConvHipImplicitGemmGroupWrwXdlopsentry was removed; every other solver's entry for those keys is untouched:Changes
projects/miopen/src/kernels/gfx950100.HIP.fdb.txt.bz2/gfx950100.db.txt.bz2— the 2 stale entries removed.test/therock/test_miopen.py— removed the"gfx950-dcgpu": {"linux": ["*DBSync*"]}exclusion and theTODO(rocm-libraries#2266)guard, so gfx950 dbsync now runs like every other family.Test Plan
StaticFDBSync[gfx950]passes cleanly under rocjitsu against the fixed DB (0 failures, verified in a fresh process)..bz2files against their pre-compression content (byte-identical decompress).*DBSync*filter passes forgfx950-dcgpuon a real run.🤖 Generated with Claude Code