Skip to content

(feat) rocprim, rocthrust, hipcub, hiprand, rocrand - Fix version numbers for ROCm 10.0 - #10879

Merged
marbre merged 1 commit into
release/therock-10.0from
users/stanleytsang-amd/cp-prim-version-fix-10.0
Aug 17, 2026
Merged

marbre merged 1 commit into
release/therock-10.0from
users/stanleytsang-amd/cp-prim-version-fix-10.0

Conversation

@stanleytsang-amd

@stanleytsang-amd stanleytsang-amd commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Cherry-picks commit 6b2e697 into the ROCm 10.0 release branch.

See #10759. The PR fixes the version numbers for the prims libraries as the CCCL 3.0 changes were rolled back.

Technical Details

Correctly sets the version numbers and branches to pull from.

Test Plan

Ran CI on #10759 .

Test Result

All tests passed except the hiprand gfx950 job, which seems to come from machine issues (kernel launch failures) that I cannot reproduce locally.

Submission Checklist

@stanleytsang-amd
stanleytsang-amd requested review from a team August 17, 2026 17:52
@stanleytsang-amd
stanleytsang-amd requested review from a team as code owners August 17, 2026 17:52
@marbre

marbre commented Aug 17, 2026

Copy link
Copy Markdown
Member

@stanleytsang-amd, rocthrust tests running on Windows fails on gfx1151:

672: [ RUN      ] ZipIteratorStableSortByKeyTests/1.TestZipIteratorStableSortByKey
672: C:/home/runner/_work/rocm-libraries/rocm-libraries/projects/rocthrust/test/test_zip_iterator_sort_by_key.cpp(63): error: Expressions during equality check:
672:   h3
672:   d3

The test is passing on the original PR. Is this a known issue on ROCm 10.0?

@stanleytsang-amd

Copy link
Copy Markdown
Contributor Author

@stanleytsang-amd, rocthrust tests running on Windows fails on gfx1151:

672: [ RUN      ] ZipIteratorStableSortByKeyTests/1.TestZipIteratorStableSortByKey
672: C:/home/runner/_work/rocm-libraries/rocm-libraries/projects/rocthrust/test/test_zip_iterator_sort_by_key.cpp(63): error: Expressions during equality check:
672:   h3
672:   d3

The test is passing on the original PR. Is this a known issue on ROCm 10.0?

The failure is due to a known compiler bug that we've filed a ticket internally for. It is intermittent in nature.

@marbre
marbre merged commit 3910399 into release/therock-10.0 Aug 17, 2026
104 of 121 checks passed
@marbre
marbre deleted the users/stanleytsang-amd/cp-prim-version-fix-10.0 branch August 17, 2026 21:48
marbre added a commit to ROCm/TheRock that referenced this pull request Aug 19, 2026
Bumps rocm-libraries to include cherry-picks for JIRA ID AIRDEL-36

* ROCm/rocm-libraries#10637
* ROCm/rocm-libraries#10879
* ROCm/rocm-libraries#10967
* ROCm/rocm-libraries#10991
marbre added a commit to ROCm/TheRock that referenced this pull request Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants