Repository navigation
feat(hipfft): implement JIT callback API, deprecate function pointer API - #10875
Merged
Merged
Conversation
evetsso
force-pushed
the
users/evetsso/jit_callback_api_hipfft
branch
from
August 19, 2026 22:07
a79f088 to
2cb31bf
Compare
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
evetsso
force-pushed
the
users/evetsso/jit_callback_api_hipfft
branch
from
August 19, 2026 22:29
2cb31bf to
3c882c9
Compare
evetsso
force-pushed
the
users/evetsso/jit_callback_api_hipfft
branch
from
August 20, 2026 22:59
3c882c9 to
29973f1
Compare
evetsso
force-pushed
the
users/evetsso/jit_callback_api_hipfft
branch
from
August 20, 2026 23:10
29973f1 to
4badd37
Compare
regan-amd
reviewed
Aug 22, 2026
regan-amd
left a comment
regan-amd
left a comment
Contributor
There was a problem hiding this comment.
- The multi-gpu label was added to the PR, FYI.
- I believe we should reset the default
callback_probto 0.1 in hipfft-test.
regan-amd
reviewed
Aug 24, 2026
1 task done
regan-amd
approved these changes
Aug 26, 2026
regan-amd
left a comment
regan-amd
left a comment
Contributor
There was a problem hiding this comment.
Just some extra suggestions/thoughts about the latest changes: I let you judge about them.
regan-amd
approved these changes
Aug 26, 2026
anisha-amd
reviewed
Aug 27, 2026
anisha-amd
left a comment
anisha-amd
left a comment
Contributor
There was a problem hiding this comment.
Minor comments and suggestions, thank you!!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10875 +/- ##
===========================================
+ Coverage 69.35% 69.68% +0.33%
===========================================
Files 2810 2810
Lines 464609 464722 +113
Branches 68557 68585 +28
===========================================
+ Hits 322227 323816 +1589
+ Misses 118866 117383 -1483
- Partials 23516 23523 +7
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
regan-amd
reviewed
Aug 27, 2026
regan-amd
left a comment
regan-amd
left a comment
Contributor
There was a problem hiding this comment.
Just another suggestion if we have bandwidth for it.
regan-amd
approved these changes
Aug 27, 2026
JIRA ID: AIFFT-5 New APIs to allow specifying JIT callbacks: - hipFFT: * hipfftXtSetJITCallback In rocFFT-backed hipFFT, the callback function is specified as SPIR-V bitcode. cuFFT-backed hipFFT accepts LTO-IR bitcode. Enabled JIT callback tests and removed the running of function pointer callback tests by default. Function pointer callbacks may still be explicitly requested for manual tests with --callback=funcptr.
- consistently say SPIR-V is bitcode - clang++ -> amdclang++ - add section with description and example for passing data to callbacks - align load/store API docs
- don't talk about plan descriptions in changelog - clarify deprecation message - allow clearing JIT callbacks
evetsso
force-pushed
the
users/evetsso/jit_callback_api_hipfft
branch
from
August 28, 2026 14:16
08f24aa to
79945c3
Compare
anisha-amd
approved these changes
Aug 28, 2026
anisha-amd
left a comment
anisha-amd
left a comment
Contributor
There was a problem hiding this comment.
Single suggestion comment, thank you!!
…t_callback_api_hipfft
Also put the multi-GPU + callback kernels in the same place as the other coverage kernels, since the db is designed to be appended to. Might save some compilation time.
eng-flavio-teixeira
approved these changes
Aug 31, 2026
1 task done
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
JIRA ID: AIFFT-9
New APIs to allow specifying JIT callbacks:
Technical Details
In rocFFT-backed hipFFT, the callback function is specified as SPIR-V bitcode. cuFFT-backed hipFFT accepts LTO-IR bitcode.
Enabled JIT callback tests and removed the running of function pointer callback tests by default. Function pointer callbacks may still be explicitly requested for manual tests with --callback=funcptr.
Test Plan
New test cases cover JIT callbacks.
Test Result
Tests pass.
Submission Checklist