refactor(hostnumerics): share host validation across GEMM clients

.github/CODEOWNERS

@@ -118,8 +118,9 @@
 /projects/rocwmma/                                  @ROCm/rocwmma-reviewers
 /projects/rpp/                                      @ROCm/rpp-reviewers
 /shared/origami/                                    @ROCm/origami-reviewers
-/shared/mxdatagenerator/                            @ROCm/rocroller-developers
+# Temporary while the HostNumerics extraction remains experimental.
 /shared/hostnumerics/                               @newling
+/shared/mxdatagenerator/                            @newling
 /shared/rocroller/                                  @ROCm/rocroller-developers
 /shared/tensile/                                    @ROCm/tensile-reviewers
 /shared/stinkytofu/                                 @ROCm/stinkytofu-reviewers
@@ -142,9 +143,6 @@
 /shared/hostnumerics/**/*.cmake.in                  @ROCm/rocm-math-lib-build-infra
 /shared/hostnumerics/**/CMakeLists.txt              @ROCm/rocm-math-lib-build-infra
 
-/shared/mxdatagenerator/**/*.cmake                  @ROCm/rocm-math-lib-build-infra
-/shared/mxdatagenerator/**/CMakeLists.txt           @ROCm/rocm-math-lib-build-infra
-
 /shared/origami/**/*.cmake                          @ROCm/rocm-math-lib-build-infra
 /shared/origami/**/CMakeLists.txt                   @ROCm/rocm-math-lib-build-infra
 

.github/labeler.yml

@@ -13,6 +13,7 @@
 "project: hipblaslt":
 - changed-files:
   - any-glob-to-any-file: 'projects/hipblaslt/**/*'
+  - any-glob-to-any-file: 'shared/hostnumerics/**/*'
   - any-glob-to-any-file: 'shared/origami/**/*'
   - any-glob-to-any-file: 'shared/stinkytofu/**/*'
 
@@ -143,10 +144,6 @@
 - changed-files:
   - any-glob-to-any-file: 'projects/rpp/**/*'
 
-"shared: mxdatagenerator":
-- changed-files:
-  - any-glob-to-any-file: 'shared/mxdatagenerator/**/*'
-
 "shared: origami":
 - changed-files:
   - any-glob-to-any-file: 'shared/origami/**/*'

.github/repos-config.json

@@ -27,15 +27,6 @@
       "auto_subtree_push": false,
       "monorepo_source_of_truth": true
     },
-    {
-      "name": "mxdatagenerator",
-      "url": "ROCm/mxDataGenerator",
-      "branch": "develop",
-      "category": "shared",
-      "auto_subtree_pull": false,
-      "auto_subtree_push": true,
-      "monorepo_source_of_truth": true
-    },
     {
       "name": "composablekernel",
       "url": "ROCm/composable_kernel",

.github/scripts/validate_hostnumerics_install.py

@@ -0,0 +1,177 @@
+#!/usr/bin/env python3
+# Copyright Advanced Micro Devices, Inc., or its affiliates.
+# SPDX-License-Identifier: MIT
+
+"""Validate the HostNumerics install tree against its source and manifest."""
+
+from __future__ import annotations
+
+import argparse
+import os
+import re
+import sys
+from pathlib import Path
+
+
+class ValidationError(RuntimeError):
+    """An install invariant was not satisfied."""
+
+
+def _files_below(root: Path) -> set[Path]:
+    return {
+        path.relative_to(root)
+        for path in root.rglob("*")
+        if path.is_file() or path.is_symlink()
+    }
+
+
+def _display_paths(paths: set[Path]) -> str:
+    return "\n".join(f"  {path.as_posix()}" for path in sorted(paths))
+
+
+def _manifest_entries(manifest: Path, install_prefix: Path) -> set[Path]:
+    try:
+        entries = [Path(line) for line in manifest.read_text().splitlines() if line]
+    except OSError as error:
+        raise ValidationError(
+            f"could not read install manifest {manifest}: {error}"
+        ) from error
+
+    prefix = Path(os.path.abspath(install_prefix))
+    relative_entries: set[Path] = set()
+    outside_prefix: set[Path] = set()
+    for entry in entries:
+        absolute_entry = Path(os.path.abspath(entry))
+        try:
+            relative_entries.add(absolute_entry.relative_to(prefix))
+        except ValueError:
+            outside_prefix.add(absolute_entry)
+
+    if outside_prefix:
+        raise ValidationError(
+            "install manifest contains paths outside the install prefix:\n"
+            f"{_display_paths(outside_prefix)}"
+        )
+    return relative_entries
+
+
+def _validate_install_tree(
+    source_dir: Path, build_dir: Path, install_prefix: Path
+) -> None:
+    public_include_dir = source_dir / "include"
+    installed_include_dir = install_prefix / "include"
+    manifest = build_dir / "install_manifest.txt"
+
+    if not public_include_dir.is_dir():
+        raise ValidationError(
+            f"public include directory is missing: {public_include_dir}"
+        )
+    if not installed_include_dir.is_dir():
+        raise ValidationError(
+            f"installed include directory is missing: {installed_include_dir}"
+        )
+
+    # Public headers generated from templates are installed without the .in suffix.
+    expected_public_files = {
+        path.with_suffix("") if path.suffix == ".in" else path
+        for path in _files_below(public_include_dir)
+    }
+    package_config = (build_dir / "HostNumericsConfig.cmake").read_text()
+    if re.search(r"set\(\s*HostNumerics_BLAS_AVAILABLE\s+OFF\s*\)", package_config):
+        expected_public_files.discard(Path("roc/hostnumerics/backends/blas.hpp"))
+    if not expected_public_files:
+        raise ValidationError(f"no public files found below {public_include_dir}")
+
+    installed_public_files = _files_below(installed_include_dir)
+    manifest_entries = _manifest_entries(manifest, install_prefix)
+    manifest_public_files = {
+        path.relative_to("include")
+        for path in manifest_entries
+        if path.is_relative_to("include")
+    }
+
+    missing_installed = expected_public_files - installed_public_files
+    unexpected_installed = installed_public_files - expected_public_files
+    missing_manifest = expected_public_files - manifest_public_files
+    unexpected_manifest = manifest_public_files - expected_public_files
+
+    errors: list[str] = []
+    if missing_installed:
+        errors.append(
+            "public source files missing from the install tree:\n"
+            f"{_display_paths(missing_installed)}"
+        )
+    if unexpected_installed:
+        errors.append(
+            "unexpected files installed under include/:\n"
+            f"{_display_paths(unexpected_installed)}"
+        )
+    if missing_manifest:
+        errors.append(
+            "public source files missing from the install manifest:\n"
+            f"{_display_paths(missing_manifest)}"
+        )
+    if unexpected_manifest:
+        errors.append(
+            "unexpected include files recorded in the install manifest:\n"
+            f"{_display_paths(unexpected_manifest)}"
+        )
+
+    missing_outputs = {
+        path
+        for path in manifest_entries
+        if not (install_prefix / path).exists()
+        and not (install_prefix / path).is_symlink()
+    }
+    if missing_outputs:
+        errors.append(
+            "install manifest entries missing from the install tree:\n"
+            f"{_display_paths(missing_outputs)}"
+        )
+
+    source_license = source_dir / "LICENSE.md"
+    if source_license.is_file():
+        installed_licenses = [
+            install_prefix / path
+            for path in manifest_entries
+            if path.name == source_license.name
+        ]
+        if not any(
+            path.is_file() and path.read_bytes() == source_license.read_bytes()
+            for path in installed_licenses
+        ):
+            errors.append(
+                f"{source_license.name} was not installed from the source tree"
+            )
+
+    if errors:
+        raise ValidationError("\n".join(errors))
+
+    print(
+        f"Validated {len(expected_public_files)} public install files; "
+        "no implementation headers outside the public include tree are installed."
+    )
+
+
+def _parse_arguments() -> argparse.Namespace:
+    parser = argparse.ArgumentParser(description=__doc__)
+    parser.add_argument("--source-dir", required=True, type=Path)
+    parser.add_argument("--build-dir", required=True, type=Path)
+    parser.add_argument("--install-prefix", required=True, type=Path)
+    return parser.parse_args()
+
+
+def main() -> int:
+    arguments = _parse_arguments()
+    try:
+        _validate_install_tree(
+            arguments.source_dir, arguments.build_dir, arguments.install_prefix
+        )
+    except ValidationError as error:
+        print(f"error: {error}", file=sys.stderr)
+        return 1
+    return 0
+
+
+if __name__ == "__main__":
+    sys.exit(main())

.github/workflows/gfx1250_hipblaslt_tensilelite_test.yml

@@ -192,7 +192,7 @@ jobs:
           sparse-checkout: |
             projects/hipblaslt
             shared/origami
-            shared/mxdatagenerator
+            shared/hostnumerics
             shared/stinkytofu
             cmake
             .github/actions/ci-env

.github/workflows/hipblaslt-drop-build.yml

@@ -141,7 +141,7 @@ jobs:
             projects/hipblaslt
             projects/hipsparse
             projects/hipsparselt
-            shared/mxdatagenerator
+            shared/hostnumerics
             shared/origami
             shared/rocroller
             shared/stinkytofu