[hipblas-common] don't duplicate rocm_setup_version#1050
Merged
Conversation
Contributor
TorreZuk
commented
Aug 4, 2025
TorreZuk
commented
- fix version duplication and incorrect setup
TorreZuk
pushed a commit
that referenced
this pull request
Aug 5, 2025
This fixes a gcc issue where clang headers are being brought in by the openmp-config. Additional cleanup: Remove unnecessary options added to COMMON_LINK_LIBS. If the openmp config is not found then OpenMP::OpenMP_CXX will be the fallback for both gcc and clang.
reboss
approved these changes
Aug 5, 2025
bstefanuk
reviewed
Aug 5, 2025
davidd-amd
reviewed
Aug 5, 2025
davidd-amd
approved these changes
Aug 5, 2025
Contributor
Author
|
@ellosel go ahead and make new PR, I am trying to beat a deadline so needed to resolve conversations but new rules forcing re-run anyway. |
Contributor
Author
|
c77459b introduced the mismatched variables. Pulling the cmake variable as long as it has same version pattern should be a good fix. |
Collaborator
|
Gardner Override - Based on Math-ci Passing, rocm-ci passing, Azure Devops - compilation passing (Waiting on few tests to pass - low risk of failure) |
Contributor
Author
|
@amd-aakash can you merge it? |
assistant-librarian Bot
pushed a commit
to ROCm/hipBLAS-common
that referenced
this pull request
Aug 5, 2025
[hipblas-common] don't duplicate rocm_setup_version * fix version duplication and incorrect setup
WorldofKerry
pushed a commit
that referenced
this pull request
Aug 5, 2025
This fixes a gcc issue where clang headers are being brought in by the openmp-config. Additional cleanup: Remove unnecessary options added to COMMON_LINK_LIBS. If the openmp config is not found then OpenMP::OpenMP_CXX will be the fallback for both gcc and clang. [ROCm/hipBLAS commit: 4639103]
lajagapp
pushed a commit
that referenced
this pull request
Aug 7, 2025
This fixes a gcc issue where clang headers are being brought in by the openmp-config. Additional cleanup: Remove unnecessary options added to COMMON_LINK_LIBS. If the openmp config is not found then OpenMP::OpenMP_CXX will be the fallback for both gcc and clang. [ROCm/hipBLAS commit: 4639103]
amd-jnovotny
pushed a commit
to amd-jnovotny/rocm-libraries
that referenced
this pull request
Aug 26, 2025
This fixes a gcc issue where clang headers are being brought in by the openmp-config. Additional cleanup: Remove unnecessary options added to COMMON_LINK_LIBS. If the openmp config is not found then OpenMP::OpenMP_CXX will be the fallback for both gcc and clang. (cherry picked from commit 4639103)
amd-jnovotny
pushed a commit
to amd-jnovotny/rocm-libraries
that referenced
this pull request
Aug 26, 2025
This fixes a gcc issue where clang headers are being brought in by the openmp-config. Additional cleanup: Remove unnecessary options added to COMMON_LINK_LIBS. If the openmp config is not found then OpenMP::OpenMP_CXX will be the fallback for both gcc and clang. (cherry picked from commit 4639103) [ROCm/hipBLAS commit: 458f565]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.