Repository navigation
refactor(hipblaslt): convert gfx950 F8B8SS library logic to dict format - #10401
Merged
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_F8HS
branch
from
August 10, 2026 12:54
ed0480f to
c78f6d9
Compare
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_F8B8SS
branch
from
August 10, 2026 12:54
bd50ab4 to
ac517ba
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10401 +/- ##
========================================
Coverage 69.32% 69.32%
========================================
Files 2810 2810
Lines 465520 465520
Branches 68685 68685
========================================
Hits 322706 322706
Misses 119250 119250
Partials 23564 23564
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_F8HS
branch
from
August 21, 2026 15:55
c78f6d9 to
f3f4f96
Compare
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_F8B8SS
branch
from
August 21, 2026 15:55
ac517ba to
a1d07cd
Compare
babakpst
force-pushed
the
users/dsaffars/Lib_conv_gfx950_F8HS
branch
from
August 24, 2026 15:28
f3f4f96 to
5aa1cf8
Compare
babakpst
force-pushed
the
users/dsaffars/Lib_conv_gfx950_F8B8SS
branch
from
August 24, 2026 15:28
a1d07cd to
23b98da
Compare
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_F8HS
branch
from
August 27, 2026 11:12
5aa1cf8 to
b8962d3
Compare
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_F8B8SS
branch
from
August 27, 2026 11:12
23b98da to
1c993c8
Compare
babakpst
approved these changes
Aug 27, 2026
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_F8HS
branch
from
August 31, 2026 11:32
b8962d3 to
5c2eb66
Compare
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_F8B8SS
branch
from
August 31, 2026 11:34
1c993c8 to
ca4eab4
Compare
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_F8HS
branch
from
August 31, 2026 11:51
5c2eb66 to
f79dedb
Compare
Convert 13 gfx950 F8B8SS library logic YAML files from list to dict format. # Batch: F8B8SS # Per-file lines (before -> after): gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bjlk_F8B8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8123 gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bljk_F8B8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14362 gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bjlk_F8B8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14357 gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F8B8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22462 gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bjlk_F8B8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8123 gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bljk_F8B8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14362 gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bjlk_F8B8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14357 gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F8B8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22462 gfx950/Origami/gfx950_Cijk_Ailk_Bjlk_F8B8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8074 gfx950/Origami/gfx950_Cijk_Ailk_Bljk_F8B8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14274 gfx950/Origami/gfx950_Cijk_Alik_Bjlk_F8B8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14269 gfx950/Origami/gfx950_Cijk_Alik_Bljk_F8B8SS_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22323 gfx950_id75a3/Equality/gfx950_Cijk_Alik_Bljk_F8B8SS_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 429 -> 490 Total: 247170 -> 178038 lines across 13 files.
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_F8B8SS
branch
from
August 31, 2026 11:52
ca4eab4 to
a6e7307
Compare
dsaffars
changed the base branch from
users/dsaffars/Lib_conv_gfx950_F8HS
to
develop
August 31, 2026 12:06
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID: AIHPBLAS-4216
Convert 13 gfx950 F8B8SS library logic YAML files from list to dict format.
Motivation
TensileLite is migrating gfx950 library logic YAML from the legacy list format to the canonical dict format. The dict format uses explicit root keys (
ArchitectureName,CUCount,ProblemType,Solutions, etc.) and is the formatTensileCreateLibrarynow emits by default.The F8B8SS datatype family continues the stacked gfx950 library logic conversion. Migrating these files improves maintainability, aligns shipped logic with the current serialization contract, and reduces YAML size without changing kernel selection behavior.
Technical Details
This PR converts 13 gfx950 F8B8SS library logic YAML files under:
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_nta4/projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_ntb4/projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950_id75a3/Equality/Format changes (no semantic changes intended):
MinimumRequiredVersion,ScheduleName,ArchitectureName,CUCount,DeviceNames,ProblemType, …).ProblemTypefields are nested under aProblemType:mapping instead of inline list items.Solutions:dict keyed by solution name.True/False→true/false).Scope summary:
This PR is YAML-only; no runtime, generator, or test-code changes. It builds on
users/dsaffars/Lib_conv_gfx950_F8HSin the stacked PR series.Test Plan
For each of the 13 converted files, pre-conversion list-format YAML is compared against the new dict-format YAML using a script (same parser path as
TensileCreateLibrary):Test Result
For all 13/13 F8B8SS files parsed solutions, problem types, and matching tables are semantically identical between list and dict formats.
File integrity: No files added or removed; only format conversion within the existing 13 F8B8SS logic files (Origami, Origami/Origami_nta4, Origami/Origami_ntb4, gfx950_id75a3/Equality).
Line count: Total YAML size reduced from 247,170 to 178,038 lines (~28% reduction) with no intended change to kernel selection behavior.