Skip to content

refactor(hipblaslt): convert gfx950 F8HS library logic to dict format - #10400

Merged
dsaffars merged 1 commit into
developfrom
users/dsaffars/Lib_conv_gfx950_F8HS
Sep 3, 2026
Merged

dsaffars merged 1 commit into
developfrom
users/dsaffars/Lib_conv_gfx950_F8HS

Conversation

@dsaffars

@dsaffars dsaffars commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

JIRA ID: AIHPBLAS-4216

Convert 15 gfx950 F8HS library logic YAML files from list to dict format.

Motivation

TensileLite is migrating gfx950 library logic YAML from the legacy list format to the canonical dict format. The dict format uses explicit root keys (ArchitectureName, CUCount, ProblemType, Solutions, etc.) and is the format TensileCreateLibrary now emits by default.
The F8HS datatype family continues the stacked gfx950 library logic conversion. Migrating these files improves maintainability, aligns shipped logic with the current serialization contract, and reduces YAML size without changing kernel selection behavior.

Technical Details

This PR converts 15 gfx950 F8HS library logic YAML files under:
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_nta4/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_ntb4/
Format changes (no semantic changes intended):

  • Root metadata moves from positional list entries to named keys (MinimumRequiredVersion, ScheduleName, ArchitectureName, CUCount, DeviceNames, ProblemType, …).
  • ProblemType fields are nested under a ProblemType: mapping instead of inline list items.
  • Solution entries move from list-of-flow-mappings to a Solutions: dict keyed by solution name.
  • Boolean literals are normalized (True/False → true/false).
    Scope summary:
Metric Before After
Files 15 15
Total lines 309,549 221,928

This PR is YAML-only; no runtime, generator, or test-code changes. It builds on users/dsaffars/Lib_conv_gfx950_F8B8BS in the stacked PR series.

Test Plan

For each of the 15 converted files, pre-conversion list-format YAML is compared against the new dict-format YAML using a script (same parser path as TensileCreateLibrary):

Test Result

For all 15/15 F8HS files parsed solutions, problem types, and matching tables are semantically identical between list and dict formats.
File integrity: No files added or removed; only format conversion within the existing 15 F8HS logic files (Origami, Origami/Origami_nta4, Origami/Origami_ntb4).
Line count: Total YAML size reduced from 309,549 to 221,928 lines (~28% reduction) with no intended change to kernel selection behavior.

@dsaffars
dsaffars requested a review from a team as a code owner August 5, 2026 11:20
@therock-pr-bot

therock-pr-bot Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8B8BS branch from 5923ba7 to 532adf7 Compare August 10, 2026 12:53
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8HS branch from ed0480f to c78f6d9 Compare August 10, 2026 12:54
@codecov

codecov Bot commented Aug 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10400      +/-   ##
===========================================
+ Coverage    69.32%   69.49%   +0.17%     
===========================================
  Files         2810     2810              
  Lines       465520   465521       +1     
  Branches     68685    68686       +1     
===========================================
+ Hits        322706   323504     +798     
+ Misses      119250   118446     -804     
- Partials     23564    23571       +7     
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 38.33% <ø> (ø)
TensileLite-Unit 76.15% <ø> (ø)
hipBLAS 90.62% <ø> (ø)
hipBLASLt 35.22% <ø> (ø)
hipCUB 82.68% <ø> (ø) Carriedforward from b4f07c6
hipDNN 86.85% <ø> (+<0.01%) ⬆️
hipFFT 45.62% <ø> (+1.83%) ⬆️
hipRAND 76.12% <ø> (ø) Carriedforward from b4f07c6
hipSOLVER 68.92% <ø> (ø)
hipSPARSE 86.99% <ø> (ø)
rocBLAS 48.29% <ø> (ø)
rocFFT 48.74% <ø> (+2.14%) ⬆️
rocRAND 56.91% <ø> (ø) Carriedforward from b4f07c6
rocSOLVER 76.83% <ø> (ø)
rocSPARSE 74.60% <ø> (ø)
rocThrust 91.60% <ø> (ø) Carriedforward from b4f07c6

*This pull request uses carry forward flags. Click here to find out more.
see 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8HS branch from c78f6d9 to f3f4f96 Compare August 21, 2026 15:55
@babakpst
babakpst force-pushed the users/dsaffars/Lib_conv_gfx950_F8B8BS branch from 034a9b0 to 62ef4c2 Compare August 24, 2026 15:28
@babakpst
babakpst force-pushed the users/dsaffars/Lib_conv_gfx950_F8HS branch from f3f4f96 to 5aa1cf8 Compare August 24, 2026 15:28
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8B8BS branch from 62ef4c2 to e225fba Compare August 27, 2026 11:12
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8HS branch from 5aa1cf8 to b8962d3 Compare August 27, 2026 11:12
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8HS branch from b8962d3 to 5c2eb66 Compare August 31, 2026 11:32
@dsaffars
dsaffars requested review from a team as code owners August 31, 2026 11:32
Convert 15 gfx950 F8HS library logic YAML files from list
to dict format.

# Batch: F8HS
# Per-file lines (before -> after):
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bjlk_F8HS_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8123
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bljk_F8HS_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14362
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bjlk_F8HS_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14357
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F8HS_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22462
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F8HS_MXAE8B32_MXBE8B32_BH_Bias_HA_S_SAB_SAV_UserArgs.yaml: 20936 -> 14812
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bjlk_F8HS_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8123
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bljk_F8HS_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14362
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bjlk_F8HS_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14357
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F8HS_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22462
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F8HS_MXAE8B32_MXBE8B32_BH_Bias_HA_S_SAB_SAV_UserArgs.yaml: 20936 -> 14812
  gfx950/Origami/gfx950_Cijk_Ailk_Bjlk_F8HS_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8074
  gfx950/Origami/gfx950_Cijk_Ailk_Bljk_F8HS_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14274
  gfx950/Origami/gfx950_Cijk_Alik_Bjlk_F8HS_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14269
  gfx950/Origami/gfx950_Cijk_Alik_Bljk_F8HS_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22323
  gfx950/Origami/gfx950_Cijk_Alik_Bljk_F8HS_MXAE8B32_MXBE8B32_BH_Bias_HA_S_SAB_SAV_UserArgs.yaml: 20936 -> 14756
Total: 309549 -> 221928 lines across 15 files.
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8HS branch from 5c2eb66 to f79dedb Compare August 31, 2026 11:51
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8B8BS branch from 1a67783 to aefda0c Compare August 31, 2026 11:51

@malcolmroberts malcolmroberts left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to touch rocfft. Could you please clean up the tags (this PR tags about a dozen projects)?

@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants