Skip to content

refactor(hipblaslt): convert gfx950 F8F8S library logic to dict format - #10398

Merged
dsaffars merged 1 commit into
developfrom
users/dsaffars/Lib_conv_gfx950_F8F8S
Sep 1, 2026
Merged

dsaffars merged 1 commit into
developfrom
users/dsaffars/Lib_conv_gfx950_F8F8S

Conversation

@dsaffars

@dsaffars dsaffars commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

JIRA ID: AIHPBLAS-4216

Convert 26 gfx950 F8F8S library logic YAML files from list to dict format.

Motivation

TensileLite is migrating gfx950 library logic YAML from the legacy list format to the canonical dict format. The dict format uses explicit root keys (ArchitectureName, CUCount, ProblemType, Solutions, etc.) and is the format TensileCreateLibrary now emits by default.
The F8F8S datatype family continues the stacked gfx950 library logic conversion. Migrating these files improves maintainability, aligns shipped logic with the current serialization contract, and reduces YAML size without changing kernel selection behavior.

Technical Details

This PR converts 26 gfx950 F8F8S library logic YAML files under:
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Equality/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_nta4/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_ntb4/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950_id75a3/Equality/
Format changes (no semantic changes intended):

  • Root metadata moves from positional list entries to named keys (MinimumRequiredVersion, ScheduleName, ArchitectureName, CUCount, DeviceNames, ProblemType, …).
  • ProblemType fields are nested under a ProblemType: mapping instead of inline list items.
  • Solution entries move from list-of-flow-mappings to a Solutions: dict keyed by solution name.
  • Boolean literals are normalized (True/False → true/false).
    Scope summary:
Metric Before After
Files 26 26
Total lines 494,106 355,940

This PR is YAML-only; no runtime, generator, or test-code changes. It builds on users/dsaffars/Lib_conv_gfx950_F8SS in the stacked PR series.

Test Plan

For each of the 26 converted files, pre-conversion list-format YAML is compared against the new dict-format YAML using a script (same parser path as TensileCreateLibrary):

Test Result

For all 26/26 F8F8S files parsed solutions, problem types, and matching tables are semantically identical between list and dict formats.
File integrity: No files added or removed; only format conversion within the existing 26 F8F8S logic files (Equality, Origami, Origami/Origami_nta4, Origami/Origami_ntb4, gfx950_id75a3/Equality).
Line count: Total YAML size reduced from 494,106 to 355,940 lines (~28% reduction) with no intended change to kernel selection behavior.

@dsaffars
dsaffars requested a review from a team as a code owner August 5, 2026 11:13
@therock-pr-bot

therock-pr-bot Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8SS branch from 5b50e1a to 56c1864 Compare August 10, 2026 12:53
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8F8S branch from 394c66e to 10ec53c Compare August 10, 2026 12:53
@codecov

codecov Bot commented Aug 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10398   +/-   ##
========================================
  Coverage    69.32%   69.32%           
========================================
  Files         2810     2810           
  Lines       465520   465520           
  Branches     68685    68685           
========================================
  Hits        322706   322706           
  Misses      119250   119250           
  Partials     23564    23564           
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 38.33% <ø> (ø)
TensileLite-Unit 76.15% <ø> (ø)
hipBLAS 90.62% <ø> (ø) Carriedforward from b4f07c6
hipBLASLt 35.22% <ø> (ø)
hipCUB 82.68% <ø> (ø) Carriedforward from b4f07c6
hipDNN 86.85% <ø> (ø) Carriedforward from b4f07c6
hipFFT 43.78% <ø> (ø) Carriedforward from b4f07c6
hipRAND 76.12% <ø> (ø) Carriedforward from b4f07c6
hipSOLVER 68.92% <ø> (ø) Carriedforward from b4f07c6
hipSPARSE 86.99% <ø> (ø) Carriedforward from b4f07c6
rocBLAS 48.29% <ø> (ø) Carriedforward from b4f07c6
rocFFT 46.60% <ø> (ø) Carriedforward from b4f07c6
rocRAND 56.91% <ø> (ø) Carriedforward from b4f07c6
rocSOLVER 76.83% <ø> (ø) Carriedforward from b4f07c6
rocSPARSE 74.60% <ø> (ø) Carriedforward from b4f07c6
rocThrust 91.60% <ø> (ø) Carriedforward from b4f07c6

*This pull request uses carry forward flags. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8F8S branch from 10ec53c to 673459a Compare August 21, 2026 15:55
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8SS branch from 56c1864 to 0aea4f3 Compare August 21, 2026 15:55
@babakpst
babakpst force-pushed the users/dsaffars/Lib_conv_gfx950_F8SS branch from 0aea4f3 to 9efc1b6 Compare August 24, 2026 15:28
@babakpst
babakpst force-pushed the users/dsaffars/Lib_conv_gfx950_F8F8S branch from 673459a to 50cbfa0 Compare August 24, 2026 15:28
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8F8S branch from 50cbfa0 to bfa39e3 Compare August 27, 2026 11:12
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8SS branch from 342ac1e to f8fe6c1 Compare August 31, 2026 11:30
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8F8S branch from bfa39e3 to 6a16673 Compare August 31, 2026 11:31
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8SS branch from f8fe6c1 to 91bd191 Compare August 31, 2026 11:49
Convert 26 gfx950 F8F8S library logic YAML files from list
to dict format.

# Batch: F8F8S
# Per-file lines (before -> after):
  gfx950/Equality/gfx950_Cijk_Alik_Bljk_F8F8S_BH_BiasS_HAS_SAV_UserArgs.yaml: 312 -> 422
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bjlk_F8F8S_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8123
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bjlk_F8F8S_BH_BiasSHB_HAS_SAB_SCD_SAV_UserArgs.yaml: 11112 -> 8123
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bljk_F8F8S_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14362
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bljk_F8F8S_BH_BiasSHB_HAS_SAB_SCD_SAV_UserArgs.yaml: 19887 -> 14362
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bjlk_F8F8S_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14357
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bjlk_F8F8S_BH_BiasSHB_HAS_SAB_SCD_SAV_UserArgs.yaml: 19887 -> 14357
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F8F8S_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22462
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F8F8S_BH_BiasSHB_HAS_SAB_SCD_SAV_UserArgs.yaml: 31361 -> 22462
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bjlk_F8F8S_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8123
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bjlk_F8F8S_BH_BiasSHB_HAS_SAB_SCD_SAV_UserArgs.yaml: 11112 -> 8123
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bljk_F8F8S_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14362
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bljk_F8F8S_BH_BiasSHB_HAS_SAB_SCD_SAV_UserArgs.yaml: 19887 -> 14362
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bjlk_F8F8S_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14357
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bjlk_F8F8S_BH_BiasSHB_HAS_SAB_SCD_SAV_UserArgs.yaml: 19887 -> 14357
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F8F8S_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22462
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F8F8S_BH_BiasSHB_HAS_SAB_SCD_SAV_UserArgs.yaml: 31361 -> 22462
  gfx950/Origami/gfx950_Cijk_Ailk_Bjlk_F8F8S_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8074
  gfx950/Origami/gfx950_Cijk_Ailk_Bjlk_F8F8S_BH_BiasSHB_HAS_SAB_SCD_SAV_UserArgs.yaml: 11112 -> 8074
  gfx950/Origami/gfx950_Cijk_Ailk_Bljk_F8F8S_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14274
  gfx950/Origami/gfx950_Cijk_Ailk_Bljk_F8F8S_BH_BiasSHB_HAS_SAB_SCD_SAV_UserArgs.yaml: 19887 -> 14274
  gfx950/Origami/gfx950_Cijk_Alik_Bjlk_F8F8S_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14269
  gfx950/Origami/gfx950_Cijk_Alik_Bjlk_F8F8S_BH_BiasSHB_HAS_SAB_SCD_SAV_UserArgs.yaml: 19887 -> 14269
  gfx950/Origami/gfx950_Cijk_Alik_Bljk_F8F8S_BH_BiasSHB_HAS_SAB_SAV_UserArgs.yaml: 31361 -> 22323
  gfx950/Origami/gfx950_Cijk_Alik_Bljk_F8F8S_BH_BiasSHB_HAS_SAB_SCD_SAV_UserArgs.yaml: 31361 -> 22323
  gfx950_id75a3/Equality/gfx950_Cijk_Alik_Bljk_F8F8S_BH_BiasS_HAS_SAV_UserArgs.yaml: 312 -> 422
Total: 494106 -> 355940 lines across 26 files.
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8F8S branch from 6a16673 to 592d6fe Compare August 31, 2026 11:50
@dsaffars
dsaffars changed the base branch from users/dsaffars/Lib_conv_gfx950_F8SS to develop August 31, 2026 12:07
@dsaffars
dsaffars merged commit 5a6a5f0 into develop Sep 1, 2026
70 of 73 checks passed
@dsaffars
dsaffars deleted the users/dsaffars/Lib_conv_gfx950_F8F8S branch September 1, 2026 12:31
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants