Skip to content

refactor(hipblaslt): convert gfx950 F8BS library logic to dict format - #10396

Merged
dsaffars merged 1 commit into
developfrom
users/dsaffars/Lib_conv_gfx950_F8BS
Sep 3, 2026
Merged

dsaffars merged 1 commit into
developfrom
users/dsaffars/Lib_conv_gfx950_F8BS

Conversation

@dsaffars

@dsaffars dsaffars commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

JIRA ID: AIHPBLAS-4216

Convert 27 gfx950 F8BS library logic YAML files from list to dict format.

Motivation

TensileLite is migrating gfx950 library logic YAML from the legacy list format to the canonical dict format. The dict format uses explicit root keys (ArchitectureName, CUCount, ProblemType, Solutions, etc.) and is the format TensileCreateLibrary now emits by default.
The F8BS datatype family continues the stacked gfx950 library logic conversion. Migrating these files improves maintainability, aligns shipped logic with the current serialization contract, and reduces YAML size without changing kernel selection behavior.

Technical Details

This PR converts 27 gfx950 F8BS library logic YAML files under:
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Equality/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_nta4/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_ntb4/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950_id75a3/Equality/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950_id75a8/Equality/
Format changes (no semantic changes intended):

  • Root metadata moves from positional list entries to named keys (MinimumRequiredVersion, ScheduleName, ArchitectureName, CUCount, DeviceNames, ProblemType, …).
  • ProblemType fields are nested under a ProblemType: mapping instead of inline list items.
  • Solution entries move from list-of-flow-mappings to a Solutions: dict keyed by solution name.
  • Boolean literals are normalized (True/False → true/false).
    Scope summary:
Metric Before After
Files 27 27
Total lines 1,571,831 1,027,746

This PR is YAML-only; no runtime, generator, or test-code changes. It builds on users/dsaffars/Lib_conv_gfx950_F8H in the stacked PR series.

Test Plan

For each of the 27 converted files, pre-conversion list-format YAML is compared against the new dict-format YAML using a script (same parser path as TensileCreateLibrary):

Test Result

For all 27/27 F8BS files parsed solutions, problem types, and matching tables are semantically identical between list and dict formats.
File integrity: No files added or removed; only format conversion within the existing 27 F8BS logic files (Equality, Origami, Origami/Origami_nta4, Origami/Origami_ntb4, gfx950_id75a3/Equality, gfx950_id75a8/Equality).
Line count: Total YAML size reduced from 1,571,831 to 1,027,746 lines (~35% reduction) with no intended change to kernel selection behavior.

@therock-pr-bot

therock-pr-bot Bot commented Aug 6, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8H branch from 9c83de2 to aa7d0e6 Compare August 10, 2026 12:53
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8BS branch from 6406129 to f0aa440 Compare August 10, 2026 12:53
@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@codecov

codecov Bot commented Aug 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10396   +/-   ##
========================================
  Coverage    69.32%   69.32%           
========================================
  Files         2810     2810           
  Lines       465520   465520           
  Branches     68685    68685           
========================================
  Hits        322706   322706           
  Misses      119250   119250           
  Partials     23564    23564           
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 38.33% <ø> (ø)
TensileLite-Unit 76.15% <ø> (ø)
hipBLAS 90.62% <ø> (ø) Carriedforward from b4f07c6
hipBLASLt 35.22% <ø> (ø)
hipCUB 82.68% <ø> (ø) Carriedforward from b4f07c6
hipDNN 86.85% <ø> (ø) Carriedforward from b4f07c6
hipFFT 43.78% <ø> (ø) Carriedforward from b4f07c6
hipRAND 76.12% <ø> (ø) Carriedforward from b4f07c6
hipSOLVER 68.92% <ø> (ø) Carriedforward from b4f07c6
hipSPARSE 86.99% <ø> (ø) Carriedforward from b4f07c6
rocBLAS 48.29% <ø> (ø) Carriedforward from b4f07c6
rocFFT 46.60% <ø> (ø) Carriedforward from b4f07c6
rocRAND 56.91% <ø> (ø) Carriedforward from b4f07c6
rocSOLVER 76.83% <ø> (ø) Carriedforward from b4f07c6
rocSPARSE 74.60% <ø> (ø) Carriedforward from b4f07c6
rocThrust 91.60% <ø> (ø) Carriedforward from b4f07c6

*This pull request uses carry forward flags. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8H branch from aa7d0e6 to d3cfe7b Compare August 21, 2026 15:55
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8BS branch from f0aa440 to 5436838 Compare August 21, 2026 15:55
@babakpst
babakpst force-pushed the users/dsaffars/Lib_conv_gfx950_F8H branch from d3cfe7b to e1d91bd Compare August 24, 2026 15:28
@babakpst
babakpst force-pushed the users/dsaffars/Lib_conv_gfx950_F8BS branch from 5436838 to 3d8b19d Compare August 24, 2026 15:28
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8BS branch from 3d8b19d to c58db1b Compare August 27, 2026 11:12
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8H branch from 0b3773a to 2671bc4 Compare August 31, 2026 11:28
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8BS branch from c58db1b to 02810de Compare August 31, 2026 11:29
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8H branch from 2671bc4 to 173f202 Compare August 31, 2026 11:48
Convert 27 gfx950 F8BS library logic YAML files from list
to dict format.

# Batch: F8BS
# Per-file lines (before -> after):
  gfx950/Equality/gfx950_Cijk_Alik_Bljk_F8BS_BH_BiasSB_HAS_SABV_SAV_UserArgs.yaml: 74416 -> 53107
  gfx950/Equality/gfx950_Cijk_Alik_Bljk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 292825 -> 176480
  gfx950/Equality/gfx950_Cijk_Alik_Bljk_F8BS_BH_SAB_UserArgs.yaml: 1294 -> 1136
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bjlk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8123
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bljk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14362
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bjlk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14357
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F8BS_BH_BiasSB_HAS_SABV_SAV_UserArgs.yaml: 29335 -> 21021
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 47746 -> 34027
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F8BS_MXAE8B32_MXBE8B32_BH_Bias_HA_S_SAB_SAV_UserArgs.yaml: 20936 -> 14812
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bjlk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8123
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bljk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14362
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bjlk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14357
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F8BS_BH_BiasSB_HAS_SABV_SAV_UserArgs.yaml: 29335 -> 21021
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 47746 -> 34027
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F8BS_MXAE8B32_MXBE8B32_BH_Bias_HA_S_SAB_SAV_UserArgs.yaml: 20936 -> 14812
  gfx950/Origami/gfx950_Cijk_Ailk_Bjlk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 11112 -> 8074
  gfx950/Origami/gfx950_Cijk_Ailk_Bljk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14274
  gfx950/Origami/gfx950_Cijk_Alik_Bjlk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 19887 -> 14269
  gfx950/Origami/gfx950_Cijk_Alik_Bljk_F8BS_BH_BiasSB_HAS_SABV_SAV_UserArgs.yaml: 29335 -> 20891
  gfx950/Origami/gfx950_Cijk_Alik_Bljk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 47746 -> 33835
  gfx950/Origami/gfx950_Cijk_Alik_Bljk_F8BS_MXAE8B32_MXBE8B32_BH_Bias_HA_S_SAB_SAV_UserArgs.yaml: 20936 -> 14756
  gfx950_id75a3/Equality/gfx950_Cijk_Ailk_Bjlk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 19176 -> 12944
  gfx950_id75a3/Equality/gfx950_Cijk_Ailk_Bljk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 19133 -> 12856
  gfx950_id75a3/Equality/gfx950_Cijk_Alik_Bljk_F8BS_BH_BiasSB_HAS_SABV_SAV_UserArgs.yaml: 74416 -> 53107
  gfx950_id75a3/Equality/gfx950_Cijk_Alik_Bljk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 620682 -> 381514
  gfx950_id75a3/Equality/gfx950_Cijk_Alik_Bljk_F8BS_BH_SAB_UserArgs.yaml: 1294 -> 1136
  gfx950_id75a8/Equality/gfx950_Cijk_Alik_Bljk_F8BS_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 21886 -> 15963
Total: 1571831 -> 1027746 lines across 27 files.
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F8BS branch from 02810de to a77a2a8 Compare August 31, 2026 11:48
@dsaffars
dsaffars changed the base branch from users/dsaffars/Lib_conv_gfx950_F8H to develop August 31, 2026 12:08
@dsaffars
dsaffars merged commit 5904707 into develop Sep 3, 2026
111 of 116 checks passed
@dsaffars
dsaffars deleted the users/dsaffars/Lib_conv_gfx950_F8BS branch September 3, 2026 18:09
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants