Repository navigation
refactor(hipblaslt): convert gfx950 F4 library logic to dict format - #10390
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
|
Heads-up from the rocm-libraries gardener rotation: #10016 The overlap is exact — #10016 updated 3 of the 9 files this PR touches:
#10016 added 23 new MTs to those three One thing to be aware of before you push: GitHub Actions is in an active major outage right now |
cf1aac2 to
ffadd14
Compare
b71ee6b to
76b5ea8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10390 +/- ##
========================================
Coverage 69.32% 69.32%
========================================
Files 2810 2810
Lines 465520 465520
Branches 68685 68685
========================================
Hits 322706 322706
Misses 119250 119250
Partials 23564 23564
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
ffadd14 to
212aad4
Compare
1aa9506 to
bf3a5c3
Compare
212aad4 to
7c182dd
Compare
7c182dd to
8539203
Compare
bf3a5c3 to
ca5127b
Compare
ca5127b to
b22e112
Compare
2348217 to
37c8351
Compare
b22e112 to
bc41ed8
Compare
37c8351 to
71d76d3
Compare
Convert 9 gfx950 F4 library logic YAML files from list to dict format. # Batch: F4 # Per-file lines (before -> after): gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F4BS_MXA32_MXB32_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 25453 -> 18530 gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F4HS_MXA32_MXB32_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12536 gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F4SS_MXA32_MXB32_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12536 gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F4BS_MXA32_MXB32_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 25453 -> 18530 gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F4HS_MXA32_MXB32_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12536 gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F4SS_MXA32_MXB32_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12536 gfx950/Origami/gfx950_Cijk_Alik_Bljk_F4BS_MXA32_MXB32_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 25453 -> 18455 gfx950/Origami/gfx950_Cijk_Alik_Bljk_F4HS_MXA32_MXB32_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12484 gfx950/Origami/gfx950_Cijk_Alik_Bljk_F4SS_MXA32_MXB32_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12484 Total: 176811 -> 130627 lines across 9 files.
bc41ed8 to
c6bec56
Compare
TheRock Submodule Bump ActivityNewest first
|
JIRA ID: AIHPBLAS-4216
Convert 9 gfx950 F4 library logic YAML files from list to dict format.
Motivation
TensileLite is migrating gfx950 library logic YAML from the legacy list format to the canonical dict format. The dict format uses explicit root keys (
ArchitectureName,CUCount,ProblemType,Solutions, etc.) and is the formatTensileCreateLibrarynow emits by default.The F4 datatype family continues the stacked gfx950 library logic conversion. Migrating these files improves maintainability, aligns shipped logic with the current serialization contract, and reduces YAML size without changing kernel selection behavior.
Technical Details
This PR converts 9 gfx950 F4 library logic YAML files under:
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_nta4/projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_ntb4/Format changes (no semantic changes intended):
MinimumRequiredVersion,ScheduleName,ArchitectureName,CUCount,DeviceNames,ProblemType, …).ProblemTypefields are nested under aProblemType:mapping instead of inline list items.Solutions:dict keyed by solution name.True/False→true/false).Scope summary:
This PR is YAML-only; no runtime, generator, or test-code changes. It builds on
users/dsaffars/Lib_conv_gfx950_miscin the stacked PR series.Test Plan
For each of the 9 converted files, pre-conversion list-format YAML is compared against the new dict-format YAML using a script (same parser path as
TensileCreateLibrary):Test Result
For all 9/9 F4 files parsed solutions, problem types, and matching tables are semantically identical between list and dict formats.
File integrity: No files added or removed; only format conversion within the existing 9 F4 logic files (Origami, Origami/Origami_nta4, Origami/Origami_ntb4).
Line count: Total YAML size reduced from 150,678 to 112,668 lines (~25% reduction) with no intended change to kernel selection behavior.