Skip to content

refactor(hipblaslt): convert gfx950 F4 library logic to dict format - #10390

Merged
dsaffars merged 1 commit into
developfrom
users/dsaffars/Lib_conv_gfx950_F4
Sep 3, 2026
Merged

dsaffars merged 1 commit into
developfrom
users/dsaffars/Lib_conv_gfx950_F4

Conversation

@dsaffars

@dsaffars dsaffars commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

JIRA ID: AIHPBLAS-4216

Convert 9 gfx950 F4 library logic YAML files from list to dict format.

Motivation

TensileLite is migrating gfx950 library logic YAML from the legacy list format to the canonical dict format. The dict format uses explicit root keys (ArchitectureName, CUCount, ProblemType, Solutions, etc.) and is the format TensileCreateLibrary now emits by default.
The F4 datatype family continues the stacked gfx950 library logic conversion. Migrating these files improves maintainability, aligns shipped logic with the current serialization contract, and reduces YAML size without changing kernel selection behavior.

Technical Details

This PR converts 9 gfx950 F4 library logic YAML files under:
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_nta4/
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_ntb4/
Format changes (no semantic changes intended):

  • Root metadata moves from positional list entries to named keys (MinimumRequiredVersion, ScheduleName, ArchitectureName, CUCount, DeviceNames, ProblemType, …).
  • ProblemType fields are nested under a ProblemType: mapping instead of inline list items.
  • Solution entries move from list-of-flow-mappings to a Solutions: dict keyed by solution name.
  • Boolean literals are normalized (True/False → true/false).
    Scope summary:
Metric Before After
Files 9 9
Total lines 150,678 112,668

This PR is YAML-only; no runtime, generator, or test-code changes. It builds on users/dsaffars/Lib_conv_gfx950_misc in the stacked PR series.

Test Plan

For each of the 9 converted files, pre-conversion list-format YAML is compared against the new dict-format YAML using a script (same parser path as TensileCreateLibrary):

Test Result

For all 9/9 F4 files parsed solutions, problem types, and matching tables are semantically identical between list and dict formats.
File integrity: No files added or removed; only format conversion within the existing 9 F4 logic files (Origami, Origami/Origami_nta4, Origami/Origami_ntb4).
Line count: Total YAML size reduced from 150,678 to 112,668 lines (~25% reduction) with no intended change to kernel selection behavior.

@dsaffars
dsaffars requested a review from a team as a code owner August 5, 2026 09:17
@therock-pr-bot

therock-pr-bot Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@AmosLewis

Copy link
Copy Markdown
Contributor

Heads-up from the rocm-libraries gardener rotation: #10016
(perf(hipblaslt): Updating Origami libraries for MXFP4 TN for gfx950) has just landed on develop
as 934fa79, so this PR is unblocked and ready to rebase.

The overlap is exact — #10016 updated 3 of the 9 files this PR touches:

  • .../gfx950/Origami/gfx950_Cijk_Alik_Bljk_F4BS_MXA32_MXB32_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml
  • .../gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F4BS_MXA32_MXB32_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml
  • .../gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F4BS_MXA32_MXB32_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml

#10016 added 23 new MTs to those three F4BS files, so when you rebase please make sure the
dict-format conversion picks up the new entries rather than reverting them — that is the one place
where a clean textual rebase could silently drop the tuning update.

One thing to be aware of before you push: GitHub Actions is in an active major outage right now
(Actions: major_outage, see https://www.githubstatus.com), so CI on a fresh push will likely fail
in Getting action download info or sit queued for a long time. It may be worth waiting for the
incident to clear before rebasing, otherwise you will be triaging platform noise rather than real
signal.

@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_misc branch from cf1aac2 to ffadd14 Compare August 10, 2026 12:53
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F4 branch from b71ee6b to 76b5ea8 Compare August 10, 2026 12:53
@codecov

codecov Bot commented Aug 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10390   +/-   ##
========================================
  Coverage    69.32%   69.32%           
========================================
  Files         2810     2810           
  Lines       465520   465520           
  Branches     68685    68685           
========================================
  Hits        322706   322706           
  Misses      119250   119250           
  Partials     23564    23564           
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 38.33% <ø> (ø)
TensileLite-Unit 76.15% <ø> (ø)
hipBLAS 90.62% <ø> (ø) Carriedforward from b4f07c6
hipBLASLt 35.22% <ø> (ø)
hipCUB 82.68% <ø> (ø) Carriedforward from b4f07c6
hipDNN 86.85% <ø> (ø) Carriedforward from b4f07c6
hipFFT 43.78% <ø> (ø) Carriedforward from b4f07c6
hipRAND 76.12% <ø> (ø) Carriedforward from b4f07c6
hipSOLVER 68.92% <ø> (ø) Carriedforward from b4f07c6
hipSPARSE 86.99% <ø> (ø) Carriedforward from b4f07c6
rocBLAS 48.29% <ø> (ø) Carriedforward from b4f07c6
rocFFT 46.60% <ø> (ø) Carriedforward from b4f07c6
rocRAND 56.91% <ø> (ø) Carriedforward from b4f07c6
rocSOLVER 76.83% <ø> (ø) Carriedforward from b4f07c6
rocSPARSE 74.60% <ø> (ø) Carriedforward from b4f07c6
rocThrust 91.60% <ø> (ø) Carriedforward from b4f07c6

*This pull request uses carry forward flags. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_misc branch from ffadd14 to 212aad4 Compare August 21, 2026 14:48
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F4 branch 2 times, most recently from 1aa9506 to bf3a5c3 Compare August 21, 2026 16:03
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_misc branch from 212aad4 to 7c182dd Compare August 21, 2026 16:03
@babakpst
babakpst force-pushed the users/dsaffars/Lib_conv_gfx950_misc branch from 7c182dd to 8539203 Compare August 24, 2026 15:28
@babakpst
babakpst force-pushed the users/dsaffars/Lib_conv_gfx950_F4 branch from bf3a5c3 to ca5127b Compare August 24, 2026 15:28
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F4 branch from ca5127b to b22e112 Compare August 27, 2026 11:12
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_misc branch from 2348217 to 37c8351 Compare August 31, 2026 11:26
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F4 branch from b22e112 to bc41ed8 Compare August 31, 2026 11:26
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_misc branch from 37c8351 to 71d76d3 Compare August 31, 2026 11:45
Convert 9 gfx950 F4 library logic YAML files from list
to dict format.

# Batch: F4
# Per-file lines (before -> after):
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F4BS_MXA32_MXB32_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 25453 -> 18530
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F4HS_MXA32_MXB32_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12536
  gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_F4SS_MXA32_MXB32_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12536
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F4BS_MXA32_MXB32_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 25453 -> 18530
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F4HS_MXA32_MXB32_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12536
  gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_F4SS_MXA32_MXB32_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12536
  gfx950/Origami/gfx950_Cijk_Alik_Bljk_F4BS_MXA32_MXB32_BH_BiasSB_HAS_SAB_SAV_UserArgs.yaml: 25453 -> 18455
  gfx950/Origami/gfx950_Cijk_Alik_Bljk_F4HS_MXA32_MXB32_BH_BiasSH_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12484
  gfx950/Origami/gfx950_Cijk_Alik_Bljk_F4SS_MXA32_MXB32_BH_BiasS_HAS_SAB_SAV_UserArgs.yaml: 16742 -> 12484
Total: 176811 -> 130627 lines across 9 files.
@dsaffars
dsaffars force-pushed the users/dsaffars/Lib_conv_gfx950_F4 branch from bc41ed8 to c6bec56 Compare August 31, 2026 11:46
@dsaffars
dsaffars changed the base branch from users/dsaffars/Lib_conv_gfx950_misc to develop August 31, 2026 12:09
@dsaffars
dsaffars merged commit cc5aeb6 into develop Sep 3, 2026
71 of 74 checks passed
@dsaffars
dsaffars deleted the users/dsaffars/Lib_conv_gfx950_F4 branch September 3, 2026 08:13
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants