Repository navigation
refactor(hipblaslt): convert gfx950 D library logic to dict format - #10383
Merged
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_I8
branch
from
August 10, 2026 12:44
8f3f387 to
983713e
Compare
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_D
branch
from
August 10, 2026 12:53
3bfa71f to
825ba1e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10383 +/- ##
========================================
Coverage 69.32% 69.32%
========================================
Files 2810 2810
Lines 465520 465520
Branches 68685 68685
========================================
Hits 322706 322706
Misses 119250 119250
Partials 23564 23564
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_I8
branch
from
August 21, 2026 14:48
983713e to
8152f7d
Compare
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_D
branch
2 times, most recently
from
August 21, 2026 16:03
18dc7ba to
8b66121
Compare
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_I8
branch
from
August 21, 2026 16:03
8152f7d to
7f60736
Compare
babakpst
force-pushed
the
users/dsaffars/Lib_conv_gfx950_D
branch
from
August 24, 2026 15:28
8b66121 to
adae0a3
Compare
babakpst
approved these changes
Aug 24, 2026
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_D
branch
from
August 27, 2026 11:12
adae0a3 to
b012b56
Compare
babakpst
approved these changes
Aug 27, 2026
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_D
branch
from
August 31, 2026 11:25
b012b56 to
32c5abd
Compare
Convert 16 gfx950 D library logic YAML files from list to dict format. # Batch: D # Per-file lines (before -> after): gfx950/GridBased/gfx950_Cijk_Ailk_Bjlk_DB_UserArgs.yaml: 436 -> 495 gfx950/GridBased/gfx950_Cijk_Ailk_Bljk_DB_UserArgs.yaml: 436 -> 494 gfx950/GridBased/gfx950_Cijk_Alik_Bjlk_DB_UserArgs.yaml: 436 -> 495 gfx950/GridBased/gfx950_Cijk_Alik_Bljk_DB_UserArgs.yaml: 436 -> 493 gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bjlk_D_B_UserArgs.yaml: 26411 -> 18875 gfx950/Origami/Origami_nta4/gfx950_Cijk_Ailk_Bljk_D_B_UserArgs.yaml: 26411 -> 18828 gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bjlk_D_B_UserArgs.yaml: 26411 -> 18828 gfx950/Origami/Origami_nta4/gfx950_Cijk_Alik_Bljk_D_B_UserArgs.yaml: 26411 -> 18777 gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bjlk_D_B_UserArgs.yaml: 26411 -> 18875 gfx950/Origami/Origami_ntb4/gfx950_Cijk_Ailk_Bljk_D_B_UserArgs.yaml: 26411 -> 18828 gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bjlk_D_B_UserArgs.yaml: 26411 -> 18828 gfx950/Origami/Origami_ntb4/gfx950_Cijk_Alik_Bljk_D_B_UserArgs.yaml: 26411 -> 18777 gfx950/Origami/gfx950_Cijk_Ailk_Bjlk_D_B_UserArgs.yaml: 26411 -> 18758 gfx950/Origami/gfx950_Cijk_Ailk_Bljk_D_B_UserArgs.yaml: 26411 -> 18711 gfx950/Origami/gfx950_Cijk_Alik_Bjlk_D_B_UserArgs.yaml: 26411 -> 18711 gfx950/Origami/gfx950_Cijk_Alik_Bljk_D_B_UserArgs.yaml: 26411 -> 18660 Total: 318676 -> 227433 lines across 16 files.
dsaffars
force-pushed
the
users/dsaffars/Lib_conv_gfx950_D
branch
2 times, most recently
from
August 31, 2026 11:44
32c5abd to
1649369
Compare
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID: AIHPBLAS-4216
Convert 16 gfx950 D library logic YAML files from list to dict format.
Motivation
TensileLite is migrating gfx950 library logic YAML from the legacy list format to the canonical dict format. The dict format uses explicit root keys (
ArchitectureName,CUCount,ProblemType,Solutions, etc.) and is the formatTensileCreateLibrarynow emits by default.The D datatype family continues the stacked gfx950 library logic conversion. Migrating these files improves maintainability, aligns shipped logic with the current serialization contract, and reduces YAML size without changing kernel selection behavior.
Technical Details
This PR converts 16 gfx950 D library logic YAML files under:
projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/GridBased/projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_nta4/projects/hipblaslt/library/src/amd_detail/rocblaslt/src/Tensile/Logic/asm_full/gfx950/gfx950/Origami/Origami_ntb4/Format changes (no semantic changes intended):
MinimumRequiredVersion,ScheduleName,ArchitectureName,CUCount,DeviceNames,ProblemType, …).ProblemTypefields are nested under aProblemType:mapping instead of inline list items.Solutions:dict keyed by solution name.True/False→true/false).Scope summary:
This PR is YAML-only; no runtime, generator, or test-code changes. It builds on
users/dsaffars/Lib_conv_gfx950in the stacked PR series.Test Plan
For each of the 16 converted files, pre-conversion list-format YAML is compared against the new dict-format YAML using a script (same parser path as
TensileCreateLibrary):Test Result
For all 16/16 D files parsed solutions, problem types, and matching tables are semantically identical between list and dict formats.
File integrity: No files added or removed; only format conversion within the existing 16 D logic files (GridBased, Origami, Origami/Origami_nta4, Origami/Origami_ntb4).
Line count: Total YAML size reduced from 318,676 to 227,433 lines (~29% reduction) with no intended change to kernel selection behavior.