Repository navigation
feat(hipdnn): add persistent graph UUIDs - #10377
Merged
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
…ph-uuid-identity # Conflicts: # projects/hipdnn/backend/src/PlatformUtils.windows.cpp # projects/hipdnn/backend/tests/descriptors/TestGraphDescriptor.cpp # projects/hipdnn/flatbuffers_sdk/include/hipdnn_flatbuffers_sdk/utilities/json/Graph.hpp
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #10377 +/- ##
===========================================
+ Coverage 68.93% 69.49% +0.56%
===========================================
Files 2766 2765 -1
Lines 455651 455061 -590
Branches 67164 67107 -57
===========================================
+ Hits 314073 316201 +2128
+ Misses 118689 115911 -2778
- Partials 22889 22949 +60
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
SamuelReeder
commented
Aug 6, 2026
SamuelReeder
marked this pull request as ready for review
August 6, 2026 13:53
8 of 9 tasks
BrianHarrisonAMD
approved these changes
Aug 11, 2026
BrianHarrisonAMD
left a comment
Contributor
There was a problem hiding this comment.
LGTM thanks for the updates!
I think this could benefit from a bit deeper testing before merge.
SamuelReeder
force-pushed
the
users/sareeder/graph-uuid-identity
branch
from
August 11, 2026 03:43
eab1d6b to
f3abf6f
Compare
SamuelReeder
force-pushed
the
users/sareeder/graph-uuid-identity
branch
from
August 11, 2026 03:49
f3abf6f to
fe743e9
Compare
mousdahl-amd
approved these changes
Aug 11, 2026
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a persistent opaque 128-bit identity generated at UUID v4 to finalized hipDNN serialized graphs so providers can identify graph instances without content hashing or structural comparison. The ID survives binary and JSON round trips, remains stable for immutable graph contents, and is replaced after graph mutation.
JIRA ID : ALMIOPEN-2391
Risk Assessment
Medium risk. This adds a backward-compatible serialized graph field and changes graph finalization/serialization behavior on Linux and Windows; local SDK and backend unit suites cover generation, compatibility, validation, and round-trip behavior.
ASIC Coverage
Standard PR CI is sufficient. This is ASIC-independent descriptor serialization and platform-RNG plumbing; it does not change kernel selection, provider support surface, or default dispatch behavior.
Testing Summary
Testing Checklist
build-uuid/bin/hipdnn_flatbuffers_sdk_tests- Status: Passed (166 tests)build-uuid/bin/hipdnn_backend_tests- Status: Passed (3,367 tests)cmake --build build-uuid --target hipdnn_flatbuffers_sdk_tests hipdnn_backend_tests- Status: PassedTechnical Changes
Graphschema with an optional, backward-compatible opaque 128-bit identity and adds canonical JSON support.