[rocPRIM][Cherry Pick] Fix rocPRIM block_shuffle syntax error#1030
Merged
vamovsik merged 4 commits intoAug 7, 2025
Conversation
xiaohuguo2023
pushed a commit
to xiaohuguo2023/rocm-libraries
that referenced
this pull request
Aug 3, 2025
spolifroni-amd
approved these changes
Aug 5, 2025
NguyenNhuDi
deleted the
zenguyen/NguyenNhuDi/fix-rocprim-block-shuffle-syntax-cherry-pick
branch
NguyenNhuDi
restored the
zenguyen/NguyenNhuDi/fix-rocprim-block-shuffle-syntax-cherry-pick
branch
stanleytsang-amd
approved these changes
Aug 5, 2025
…prim-block-shuffle-syntax-cherry-pick
…prim-block-shuffle-syntax-cherry-pick
vamovsik
deleted the
zenguyen/NguyenNhuDi/fix-rocprim-block-shuffle-syntax-cherry-pick
branch
assistant-librarian Bot
pushed a commit
to ROCm/rocPRIM
that referenced
this pull request
Aug 7, 2025
[rocPRIM][Cherry Pick] Fix rocPRIM block_shuffle syntax error (#1030) There were a few occurrences where the wrong access operator was used for an array. This PR changes from using the pointer operator (->) to using the correct dot (.) operator for arrays.
ammallya
pushed a commit
that referenced
this pull request
Sep 26, 2025
## Motivation <!-- Explain the purpose of this PR and the goals it aims to achieve. --> Add version numbers to the changelog ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> Edit changlog file ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> NA ## Test Result <!-- Briefly summarize test outcomes. --> NA ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
ammallya
pushed a commit
that referenced
this pull request
Sep 26, 2025
## Motivation <!-- Explain the purpose of this PR and the goals it aims to achieve. --> Add version numbers to the changelog ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> Edit changlog file ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> NA ## Test Result <!-- Briefly summarize test outcomes. --> NA ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. [ROCm/rocSOLVER commit: 27eba46]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few occurrences where the wrong access operator was used for an array. This PR changes from using the pointer operator (->) to using the correct dot (.) operator for arrays.