Skip to content

test(rocke): bench cases conv - #10059

Merged
bartekxk merged 10 commits into
developfrom
users/barkocot/aick-1742
Aug 8, 2026
Merged

bartekxk merged 10 commits into
developfrom
users/barkocot/aick-1742

Conversation

@bartekxk

@bartekxk bartekxk commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Enable possiblity to compare rocke conv kernels with CK kernels.

Technical Details

  • add possiblity to run ck conv kernels
  • new bench shapes

Test Plan

N/A

Test Result

N/A

Submission Checklist

Changes are behind the feature flag HIPKERNELPROVIDER_ENABLE_ROCKE which is defaulted to OFF.

JIRA ID: AICK-1742

@therock-pr-bot

therock-pr-bot Bot commented Jul 28, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: dnn-providers/hip-kernel-provider/rocke/platform/python/rocke/benchmark/benchmark_implicit_gemm_conv.py; no test file found
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@bartekxk
bartekxk requested a review from Copilot July 30, 2026 11:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@bartekxk bartekxk self-assigned this Jul 30, 2026
@bartekxk
bartekxk marked this pull request as ready for review July 30, 2026 11:50
@bartekxk
bartekxk requested review from a team as code owners July 30, 2026 11:50
@bartekxk bartekxk closed this Aug 5, 2026
@bartekxk bartekxk reopened this Aug 5, 2026
@bartekxk
bartekxk enabled auto-merge (squash) August 7, 2026 08:42
@github-actions github-actions Bot added the rocke: platform Touches rocKE platform label Aug 7, 2026
@bartekxk
bartekxk merged commit a2d4fa7 into develop Aug 8, 2026
57 checks passed
@bartekxk
bartekxk deleted the users/barkocot/aick-1742 branch August 8, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants