Repository navigation
feat(ck-tile): add tile engine dispatcher bridges for 5 block_scale_g… - #10018
Closed
ThruptiRajLakshmanaGowda wants to merge 2 commits into
Closed
ThruptiRajLakshmanaGowda wants to merge 2 commits into
ThruptiRajLakshmanaGowda wants to merge 2 commits into
Conversation
…emm operators Add registry-bypass, single-kernel-per-.so TE→Dispatcher bridges for all five block_scale_gemm operators, following the pattern established by the merged grouped_gemm_bquant bridge (PR #9166) and mxgemm bridge (PR #9329). Each operator gets four files: - codegen/unified_gemm_{op}_codegen.py — per-kernel .hpp generator - bindings/ctypes/gemm_{op}_ctypes_lib.cpp — C ABI calling SelectedKernel::launch(QuantGemmHostArgs) - python/gemm_{op}_utils.py — KernelConfig / DispatcherLib / GpuRunner / build helpers - tests/test_gemm_{op}_utils.py — 164 CPU-only unit tests total, all passing Operators and QuantType mappings: gemm_bquant → QuantType::BQuantGrouped (gemm_bquant_* naming, block_scale_gemm) gemm_aquant → QuantType::AQuantGrouped (AQ=[M,QK_A], BQ=nullptr) gemm_abquant → QuantType::ABQuantGrouped (AQ row-major, BQ col-major [QK_B,QN_B]) gemm_rowcolquant → QuantType::RowColQuant (AQ=[M,1], BQ=[1,N], no preshuffle) gemm_tensorquant → QuantType::TensorQuant (AQ and BQ single scalars) Key implementation notes: - All ctypes libs exclude dispatcher/include to avoid QuantGemmHostArgs conflicts - rowcolquant TileGemmQuantTraits needs extra UsePersistentKernel+16 args - tensorquant uses BaseWeightPreshufflePipelineAGmemBGmemCRegV2 (not BaseGemmPipelineAgBgCrCompV3) - gemm_bquant uses "default" epilogue (DefaultGemm2DEpilogue), distinct from grouped_gemm_bquant Also adds: - codegen_common.py: make_gemm_bquant/aquant/abquant/rowcolquant/tensorquant_kernel_name helpers - CMakeLists.txt: 5 new double-guarded CMake targets (dispatcher_gemm_{op}_lib) Co-Authored-By: Claude <noreply@anthropic.com>
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
…te_bridge_blockscale
Contributor
Author
|
Changes are ported to PR : #10439 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add registry-bypass, single-kernel-per-.so TE→Dispatcher bridges for all five block_scale_gemm operators, following the pattern established by the merged grouped_gemm_bquant bridge (PR #9166) and mxgemm bridge (PR #9329).
Each operator gets four files:
Operators and QuantType mappings:
gemm_bquant → QuantType::BQuantGrouped (gemm_bquant_* naming, block_scale_gemm)
gemm_aquant → QuantType::AQuantGrouped (AQ=[M,QK_A], BQ=nullptr)
gemm_abquant → QuantType::ABQuantGrouped (AQ row-major, BQ col-major [QK_B,QN_B])
gemm_rowcolquant → QuantType::RowColQuant (AQ=[M,1], BQ=[1,N], no preshuffle)
gemm_tensorquant → QuantType::TensorQuant (AQ and BQ single scalars)
Key implementation notes:
Also adds:
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist