Repository navigation
feat: write and read the bindings in bindings/fortran - #14
Merged
Merged
Conversation
The Fortran bindings move out of the library projects into a top-level bindings/fortran tree in both monorepos: bindings/fortran/ in rocm-systems (HIP, ROCTx) and bindings/fortran/<proj>/ in rocm-libraries. --overwrite now copies each module there, and a checkout's metadata/ is read from there. The headers are still read from projects/.
Security scan found no critical or high findings on lines changed by this pull requestView the security scan run for complete reports. “New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta. |
Collaborator
Author
|
@Abuudiii Can you review this PR? |
Abuudiii
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fortran bindings move out of the library projects into a top-level
bindings/fortran/tree in both monorepos, as API consumers built against the installed libraries (RFC0015 update):projects/fortran/bindings/fortran/projects/<proj>/fortran/bindings/fortran/<proj>/--overwritenow copies each module there, and a checkout'smetadata/is read from there. The headers are still read fromprojects/.The change is
fortran_dirinsrc/common/header_sources.jl; the rest isgen.sh --help, comments, the README and the tests.Tested:
src/test/runtests.jl(592 passed) andsrc/test/gen_sh.sh;ROCM_LIBRARIES=<checkout> ./gen.sh --overwrite rocblason a rocm-libraries checkout with the new layout writesbindings/fortran/rocblas/rocblas.F90.Companion pull requests: ROCm/rocm-systems#11923, ROCm/rocm-systems#14024, the ten rocm-libraries binding pull requests, and ROCm/TheRock#9446.