Revert install location to thrust#228
Merged
Merged
Conversation
lawruble13
requested review from
doctorcolinsmith,
nunnikri and
stanleytsang-amd
nunnikri
approved these changes
Mar 28, 2022
Contributor
nunnikri
left a comment
nunnikri
left a comment
There was a problem hiding this comment.
Looks good to me.
Wrapper in opt/rocm-5.1.0-xxx/rocthrust/include/thrust
Actual files in opt/rocm-5.1.0-xxx/include/thrust
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
* Revert install location * correct whitespace [ROCm/rocThrust commit: 2667f14]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#224 incorrectly changed the header install location to
/opt/rocm/include/rocthrust/.... This PR moves it to/opt/rocm/include/thrust, including wrappers in the old location/opt/rocm/rocthrust/include/thrust.