fix: resolve out-of-memory in tests on rx9070#727
Conversation
7b63ef0 to
53c763a
Compare
|
The fix was based on the new |
stanleytsang-amd
left a comment
There was a problem hiding this comment.
@Naraenda there are build errors in this PR. I think you forgot to include the utils_device_ptr.hpp header in the unit test cpp files?
/longer_pathname_so_that_rpms_can_support_packaging_the_debug_info_for_all_os_profiles/src/rocPRIM/test/rocprim/test_device_merge.cpp:173:13: error: use of undeclared identifier 'common'
173 | common::device_ptr<key_type> d_keys_input1;
| ^
/longer_pathname_so_that_rpms_can_support_packaging_the_debug_info_for_all_os_profiles/src/rocPRIM/test/rocprim/test_device_merge.cpp:173:32: error: unexpected type name 'key_type': expected expression
173 | common::device_ptr<key_type> d_keys_input1;
| ^
/longer_pathname_so_that_rpms_can_support_packaging_the_debug_info_for_all_os_profiles/src/rocPRIM/test/rocprim/test_device_merge.cpp:173:42: error: use of undeclared identifier 'd_keys_input1'; did you mean 'keys_input1'?
173 | common::device_ptr<key_type> d_keys_input1;
@Saiyang-Zhang is currently taking this over and investigating. |
0b63a4a to
88d4f40
Compare
88d4f40 to
d7f2ad3
Compare
|
|
This change did not seem to make it in this PR ROCm/rocPRIM#727.
Fix test failure with lower memory cards This change did not seem to make it in this PR #727.
This change did not seem to make it in this PR ROCm/rocPRIM#727.
Work by @NB4444. This PR adds extra checks that skips tests that would allocate too much memory.
Closes #720