Skip to content

Add atomic_add overload for type double #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umfranzw merged 1 commit into from
Nov 25, 2024
Merged

Add atomic_add overload for type double #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rocprim/include/rocprim/intrinsics/atomic.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ namespace detail
return ::atomicAdd(address, value);
}

ROCPRIM_DEVICE ROCPRIM_INLINE
double atomic_add(double * address, double value)
{
return ::atomicAdd(address, value);
}

ROCPRIM_DEVICE ROCPRIM_INLINE unsigned long atomic_add(unsigned long* address,
unsigned long value)
{
Expand Down
3 changes: 2 additions & 1 deletion test/rocprim/test_device_histogram.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ using custom_config1 = rocprim::histogram_config<rocprim::kernel_config<128, 5>>

typedef ::testing::Types<params1<int, 10, 0, 10>,
params1<float, 10, 0, 10>,
params1<float, 10, 0, 10, float, float>,
params1<rocprim::half, 10, 0, 10>,
params1<rocprim::bfloat16, 10, 0, 10>,
params1<int8_t, 10, 0, 10>,
Expand All @@ -140,8 +141,8 @@ typedef ::testing::Types<params1<int, 10, 0, 10>,
params1<unsigned short, 65536, 0, 65536, int>,
params1<unsigned char, 10, 20, 240, unsigned char, unsigned int>,
params1<unsigned char, 256, 0, 256, short>,

params1<double, 10, 0, 1000, double, int>,
params1<double, 10, 0, 1000, double, double>,
params1<int, 123, 100, 5635, int>,
params1<double, 55, -123, +123, double, unsigned int, custom_config1>,
params1<int, 10, 0, 10, int, int, rocprim::default_config, true>>
Expand Down