Skip to content

cmake: don't set CMAKE_C_COMPILER, as rocPRIM is a CXX project - #568

Merged
evetsso merged 1 commit into
ROCm:developfrom
evetsso:no_cmake_c_compiler_develop
Jun 6, 2024
Merged

evetsso merged 1 commit into
ROCm:developfrom
evetsso:no_cmake_c_compiler_develop

Conversation

@evetsso

@evetsso evetsso commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

#567 but for develop.

@evetsso evetsso added ci:static-libraries Run CI while building static libraries labels Jun 5, 2024

@umfranzw umfranzw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@evetsso
evetsso merged commit afd963c into ROCm:develop Jun 6, 2024
stanleytsang-amd pushed a commit that referenced this pull request Jul 4, 2024
…ning rtest.py on windows (#561)

* Fixed FileNotFound error on windows

* --- (#562)

updated-dependencies:
- dependency-name: requests
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Enable external CI pipeline triggers (#560)

* updated changelog

* updated copyright in rtest.py

* fixed copyright to 2021-2024

* Update Read the Docs config to Python 3.10 and latest rocm-docs-core (#564)

* cmake: don't set CMAKE_C_COMPILER, as rocPRIM is a CXX project (#568)

* Bump rocm-docs-core from 1.2.0 to 1.4.0 in /docs/sphinx (#569)

Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.2.0 to 1.4.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.2.0...v1.4.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixed FileNotFound error on windows

* updated changelog

* updated copyright in rtest.py

* fixed copyright to 2021-2024

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joseph Macaranas <145489236+amd-jmacaran@users.noreply.github.com>
Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com>
Co-authored-by: Steve Leung <Steve.Leung@amd.com>
ammallya pushed a commit that referenced this pull request Oct 28, 2025
ammallya pushed a commit that referenced this pull request Oct 28, 2025
…ning rtest.py on windows (#561)

* Fixed FileNotFound error on windows

* --- (#562)

updated-dependencies:
- dependency-name: requests
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Enable external CI pipeline triggers (#560)

* updated changelog

* updated copyright in rtest.py

* fixed copyright to 2021-2024

* Update Read the Docs config to Python 3.10 and latest rocm-docs-core (#564)

* cmake: don't set CMAKE_C_COMPILER, as rocPRIM is a CXX project (#568)

* Bump rocm-docs-core from 1.2.0 to 1.4.0 in /docs/sphinx (#569)

Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.2.0 to 1.4.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.2.0...v1.4.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixed FileNotFound error on windows

* updated changelog

* updated copyright in rtest.py

* fixed copyright to 2021-2024

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joseph Macaranas <145489236+amd-jmacaran@users.noreply.github.com>
Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com>
Co-authored-by: Steve Leung <Steve.Leung@amd.com>

[ROCm/rocPRIM commit: 529b8b6]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:static-libraries Run CI while building static libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants