Fix toolchain-windows.cmake for HIP SDK#404
Merged
Merged
Conversation
stanleytsang-amd
requested review from
doctorcolinsmith,
saadrahim and
vince-streamhpc
This was referenced Jan 25, 2023
saadrahim
approved these changes
Jan 27, 2023
stanleytsang-amd
added a commit
that referenced
this pull request
Jan 27, 2023
* HIP SDK compatibility * Update cmake_path function in rmake.py * Fix typo * Updating copyright year * Removing unnecessary cmake compiler flags * Removing old comments, cleanup * Take python3 by default
stanleytsang-amd
added a commit
that referenced
this pull request
Jan 30, 2023
lawruble13
added a commit
that referenced
this pull request
Mar 6, 2023
* HIP SDK compatibility (#398) * HIP SDK compatibility * Update cmake_path function in rmake.py * Fix typo * Updating copyright year * double to half conversion workaround for block_reduce ReduceMultiplies test case (#401) * Directly use __builtin_amdgcn_fence (#403) This was relying on an implementation detail of the HIP headers which has been removed. Co-authored-by: Matt Arsenault <matt@MattBook.local> * Fix toolchain-windows.cmake for HIP SDK (#404) * HIP SDK compatibility * Update cmake_path function in rmake.py * Fix typo * Updating copyright year * Removing unnecessary cmake compiler flags * Removing old comments, cleanup * Take python3 by default * gfx90a tuning merge-sort and radix-sort (#397) and special case tuning for merge-sort char,double value_type * Escape right brace in regex (#407) * Escape right brace in regex * Escape parentheses * Fix package name on Windows (#411) * Add rocm-cmake path to CMAKE_PREFIX_PATH * fallback to rocm-cmake master (match other libs) * Update changelog for 5.5 cherry pick * Revert "gfx90a tuning merge-sort and radix-sort (#397)" This reverts commit cc92f03. --------- Co-authored-by: Matt Arsenault <arsenm2@gmail.com> Co-authored-by: Matt Arsenault <matt@MattBook.local> Co-authored-by: Vincent van Heertum <93536747+vince-streamhpc@users.noreply.github.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
* HIP SDK compatibility * Update cmake_path function in rmake.py * Fix typo * Updating copyright year * Removing unnecessary cmake compiler flags * Removing old comments, cleanup * Take python3 by default [ROCm/rocPRIM commit: 57ff1c3]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing unnecessary cmake flags, explicit references to "C:\Program Files..." which trip up cmake, and old comments.