Our develop with fixes to several issues by ex-rzr · Pull Request #33 · ROCm/rocPRIM

ex-rzr · 2018-11-06T03:49:37Z

Various minor fixes
Additional tests for half
Changes from develop-hip-clang

Since ROCm 1.9 has already VG20 support enabled so we can add gfx906 as target now. We can delete develop-gfx9 branch as no meaning to keep 2 branch now.

add gfx906 as target

The HIP Platform should have it's own shuffle functions, and when using HIP-Clang, we don't want to use HCC specific functions.

Deprecated CUDA function are used in hip/nvcc_detail/hip_runtime_api.h.

The compiler can't finish linking if half is used and loopback implementation is chosen using if.

Usage of reinterpret_cast for bit-casting is undefined behavior. This change fixes `half` test failures on S9300 (Fiji): rocprim.hc.device_scan rocprim.hc.device_segmented_scan rocprim.hip.device_segmented_scan

VincentSC · 2018-12-17T13:01:37Z

Changed the target from master to develop.

saadrahim

Commits should be squashed when they are related. 38c7f26 ,4610e0f, b7773ea, 919b1bc ,3f3afe1
042eacc, 8368beb, ff41d04 look related. Others are possibly related. I would prefer multiple pull requests for each issue or squashed commits.

Ignore warnings about deprecated CUDA function(s) in HIP … b8298b5
I believe the cause is external to rocPRIM. Please confirm and I can raise the issue internally. Warnings can be suppressed after confirming the issue is recorded in AMD's ticketing system.

8b0f644 Not sure why we are bumping the version if there is no release.

saadrahim

Minor concerns about the PR in the previous comment but approving to reduce QA errors. Please note the concerns in future PR.

* Use HIP API shfl functions rather than hc:: The HIP Platform should have it's own shuffle functions, and when using HIP-Clang, we don't want to use HCC specific functions. * Use HIP shfl functions for HIP-Clang * Bump rocPRIM version to 1.0.2.0 * Ignore warnings about deprecated CUDA function(s) in HIP Deprecated CUDA function are used in hip/nvcc_detail/hip_runtime_api.h. * Our develop with fixes to several issues (#33) * add gfx906 as target Since ROCm 1.9 has already VG20 support enabled so we can add gfx906 as target now. We can delete develop-gfx9 branch as no meaning to keep 2 branch now. * Update name and email for the package maintainer * Use HIP API shfl functions rather than hc:: The HIP Platform should have it's own shuffle functions, and when using HIP-Clang, we don't want to use HCC specific functions. * Use HIP shfl functions for HIP-Clang * Bump rocPRIM version to 1.0.2.0 * Ignore warnings about deprecated CUDA function(s) in HIP Deprecated CUDA function are used in hip/nvcc_detail/hip_runtime_api.h. * Fix missing initial value in BlockScan::ExclusiveSum * Improve device merge sort tests with custom types * Update .gitlab-ci.yml * Update .gitlab-ci.yml * Update .gitlab-ci.yml * Update .gitignore * Add new file * Update .gitlab-ci-gputest.yml * Update .gitlab-ci.yml * Make sure the building is done on a server that has rocm installed * Update .gitlab-ci.yml * Add gfx906 to test/extra (tests for install and package install) * Print AMDGPU_TARGETS in CMake Summary * Add tests with half and char for block-level primitives * Update tests for block_reduce * Disable loopback scan for half, add compile-time specialization choosing The compiler can't finish linking if half is used and loopback implementation is chosen using if. * Add tests with half and char for device-level primitives * Replace reinterpret_cast with __builtin_memcpy Usage of reinterpret_cast for bit-casting is undefined behavior. This change fixes `half` test failures on S9300 (Fiji): rocprim.hc.device_scan rocprim.hc.device_segmented_scan rocprim.hip.device_segmented_scan * Add option to disable Werror flag For some build systems, using -Werror will halt the entire process and cause blocking. Let's add an option to disable it, but leave it ON by default.

Block IO: Block Load and Block Store Closes #33 See merge request amd/rocPRIM!25 [ROCm/rocPRIM commit: 568ef6d]

* add gfx906 as target Since ROCm 1.9 has already VG20 support enabled so we can add gfx906 as target now. We can delete develop-gfx9 branch as no meaning to keep 2 branch now. * Update name and email for the package maintainer * Use HIP API shfl functions rather than hc:: The HIP Platform should have it's own shuffle functions, and when using HIP-Clang, we don't want to use HCC specific functions. * Use HIP shfl functions for HIP-Clang * Bump rocPRIM version to 1.0.2.0 * Ignore warnings about deprecated CUDA function(s) in HIP Deprecated CUDA function are used in hip/nvcc_detail/hip_runtime_api.h. * Fix missing initial value in BlockScan::ExclusiveSum * Improve device merge sort tests with custom types * Update .gitlab-ci.yml * Update .gitlab-ci.yml * Update .gitlab-ci.yml * Update .gitignore * Add new file * Update .gitlab-ci-gputest.yml * Update .gitlab-ci.yml * Make sure the building is done on a server that has rocm installed * Update .gitlab-ci.yml * Add gfx906 to test/extra (tests for install and package install) * Print AMDGPU_TARGETS in CMake Summary * Add tests with half and char for block-level primitives * Update tests for block_reduce * Disable loopback scan for half, add compile-time specialization choosing The compiler can't finish linking if half is used and loopback implementation is chosen using if. * Add tests with half and char for device-level primitives * Replace reinterpret_cast with __builtin_memcpy Usage of reinterpret_cast for bit-casting is undefined behavior. This change fixes `half` test failures on S9300 (Fiji): rocprim.hc.device_scan rocprim.hc.device_segmented_scan rocprim.hip.device_segmented_scan [ROCm/rocPRIM commit: 40d950b]

[rocPRIM] Add gfx1152 and gfx1153 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Motivation Enable gfx1152 and gfx1153. ## Technical Details 1. combine arrays into tables and use local macros to reduce repetition (for maintainability) 2. monkey-see-monkey-do wherever `gfx11...` was found ## Test Plan Build existing ctests for, and run them on, gfx1152 and gfx1153. ## Test Result ### <details> <summary>gfx1152 passed (click to see log)</summary> ``` INFO:root:++ Exec [/tmp/eble]$ ctest --test-dir /tmp/eble/rocm/bin/rocprim --output-o n-failure --parallel 2 --exclude-regex 'rocprim.lookback_reproducibility|rocprim.link ing|rocprim.device_merge_inplace|rocprim.device_merge_sort|rocprim.device_partition|r ocprim.device_radix_sort|rocprim.device_scan|rocprim.device_select|rocprim.device_fin d_first_of|rocprim.device_reduce_by_key' --timeout 60 Test project /tmp/eble/rocm/bin/rocprim Start 1: hip.device_api Start 2: hip.async_copy 1/73 Test #2: hip.async_copy .............................. Passed 0.01 sec Start 3: hip.ordered_block_id 2/73 Test #1: hip.device_api .............................. Passed 0.02 sec Start 4: rocprim.internal_merge_path 3/73 Test #4: rocprim.internal_merge_path ................. Passed 0.01 sec Start 5: rocprim.basic_test 4/73 Test #3: hip.ordered_block_id ........................ Passed 0.01 sec Start 6: rocprim.arg_index_iterator 5/73 Test #5: rocprim.basic_test .......................... Passed 0.01 sec Start 7: rocprim.temporary_storage_partitioning 6/73 Test #6: rocprim.arg_index_iterator .................. Passed 0.01 sec Start 8: rocprim.block_adjacent_difference 7/73 Test #7: rocprim.temporary_storage_partitioning ...... Passed 0.01 sec Start 9: rocprim.block_discontinuity 8/73 Test #8: rocprim.block_adjacent_difference ........... Passed 2.34 sec Start 10: rocprim.bit_cast 9/73 Test #10: rocprim.bit_cast ............................ Passed 0.02 sec Start 11: rocprim.block_exchange 10/73 Test #11: rocprim.block_exchange ...................... Passed 0.73 sec Start 12: rocprim.block_histogram 11/73 Test #12: rocprim.block_histogram ..................... Passed 0.54 sec Start 13: rocprim.block_load_store 12/73 Test #13: rocprim.block_load_store .................... Passed 0.44 sec Start 14: rocprim.block_sort_merge 13/73 Test #14: rocprim.block_sort_merge .................... Passed 0.02 sec Start 15: rocprim.block_sort_merge_stable 14/73 Test #15: rocprim.block_sort_merge_stable ............. Passed 0.02 sec Start 16: rocprim.block_radix_rank 15/73 Test #16: rocprim.block_radix_rank .................... Passed 0.03 sec Start 17: rocprim.block_radix_sort 16/73 Test #17: rocprim.block_radix_sort .................... Passed 4.79 sec Start 18: rocprim.block_reduce 17/73 Test #18: rocprim.block_reduce ........................ Passed 0.26 sec Start 19: rocprim.block_run_length_decode 18/73 Test #19: rocprim.block_run_length_decode ............. Passed 0.54 sec Start 20: rocprim.block_scan 19/73 Test #20: rocprim.block_scan .......................... Passed 0.04 sec Start 21: rocprim.block_shuffle 20/73 Test #21: rocprim.block_shuffle ....................... Passed 2.70 sec Start 22: rocprim.block_sort_bitonic 21/73 Test #9: rocprim.block_discontinuity ................. Passed 17.36 sec Start 23: rocprim.config_dispatch 22/73 Test #23: rocprim.config_dispatch ..................... Passed 0.09 sec Start 24: rocprim.constant_iterator 23/73 Test #24: rocprim.constant_iterator ................... Passed 0.07 sec Start 25: rocprim.counting_iterator 24/73 Test #25: rocprim.counting_iterator ................... Passed 0.07 sec Start 26: rocprim.device_batch_memcpy 25/73 Test #26: rocprim.device_batch_memcpy ................. Passed 1.20 sec Start 27: rocprim.device_binary_search 26/73 Test #27: rocprim.device_binary_search ................ Passed 0.02 sec Start 28: rocprim.device_adjacent_difference 27/73 Test #28: rocprim.device_adjacent_difference .......... Passed 0.01 sec Start 29: rocprim.device_adjacent_find 28/73 Test #29: rocprim.device_adjacent_find ................ Passed 0.01 sec Start 30: rocprim.device_find_end 29/73 Test #30: rocprim.device_find_end ..................... Passed 0.01 sec Start 31: rocprim.device_histogram 30/73 Test #22: rocprim.block_sort_bitonic .................. Passed 13.23 sec Start 32: rocprim.device_merge 31/73 Test #31: rocprim.device_histogram .................... Passed 7.85 sec Start 33: rocprim.nth_element 32/73 Test #33: rocprim.nth_element ......................... Passed 0.03 sec Start 34: rocprim.device_partial_sort 33/73 Test #34: rocprim.device_partial_sort ................. Passed 0.02 sec Start 35: rocprim.device_reduce 34/73 Test #35: rocprim.device_reduce ....................... Passed 8.94 sec Start 36: rocprim.device_run_length_encode 35/73 Test #32: rocprim.device_merge ........................ Passed 14.05 sec Start 37: rocprim.device_search 36/73 Test #37: rocprim.device_search ....................... Passed 0.02 sec Start 38: rocprim.device_segmented_radix_sort 37/73 Test #36: rocprim.device_run_length_encode ............ Passed 13.92 sec Start 39: rocprim.device_search_n 38/73 Test #39: rocprim.device_search_n ..................... Passed 0.02 sec Start 40: rocprim.device_segmented_reduce 39/73 Test #40: rocprim.device_segmented_reduce ............. Passed 5.21 sec Start 41: rocprim.device_segmented_scan 40/73 Test #41: rocprim.device_segmented_scan ............... Passed 0.02 sec Start 42: rocprim.device_transform 41/73 Test #42: rocprim.device_transform .................... Passed 13.90 sec Start 43: rocprim.discard_iterator 42/73 Test #43: rocprim.discard_iterator .................... Passed 0.07 sec Start 44: rocprim.radix_key_codec 43/73 Test #44: rocprim.radix_key_codec ..................... Pas09:54:11 [55/1943] Start 45: rocprim.predicate_iterator 44/73 Test #45: rocprim.predicate_iterator .................. Passed 0.07 sec Start 46: rocprim.reverse_iterator 45/73 Test #46: rocprim.reverse_iterator .................... Passed 0.09 sec Start 47: rocprim.rocprim_tuple 46/73 Test #47: rocprim.rocprim_tuple ....................... Passed 0.01 sec Start 48: rocprim.rocprim_types 47/73 Test #48: rocprim.rocprim_types ....................... Passed 0.01 sec Start 49: rocprim.texture_cache_iterator 48/73 Test #49: rocprim.texture_cache_iterator .............. Passed 0.01 sec Start 50: rocprim.thread 49/73 Test #50: rocprim.thread .............................. Passed 0.07 sec Start 51: rocprim.thread_algos 50/73 Test #51: rocprim.thread_algos ........................ Passed 0.35 sec Start 52: rocprim.tuple 51/73 Test #52: rocprim.tuple ............................... Passed 0.02 sec Start 53: rocprim.utils_sort_checker 52/73 Test #53: rocprim.utils_sort_checker .................. Passed 0.01 sec Start 54: rocprim.transform_iterator 53/73 Test #54: rocprim.transform_iterator .................. Passed 0.11 sec Start 55: rocprim.type_traits_interface_cpp17 54/73 Test #55: rocprim.type_traits_interface_cpp17 ......... Passed 0.01 sec Start 56: rocprim.type_traits_interface_gnupp17 55/73 Test #56: rocprim.type_traits_interface_gnupp17 ....... Passed 0.01 sec Start 57: rocprim.type_traits_interface_cpp20 56/73 Test #57: rocprim.type_traits_interface_cpp20 ......... Passed 0.01 sec Start 58: rocprim.type_traits_interface_gnupp20 57/73 Test #58: rocprim.type_traits_interface_gnupp20 ....... Passed 0.01 sec Start 59: rocprim.no_half_operators 58/73 Test #59: rocprim.no_half_operators ................... Passed 0.01 sec Start 60: rocprim.intrinsics 59/73 Test #60: rocprim.intrinsics .......................... Passed 0.21 sec Start 61: rocprim.intrinsics_atomic 60/73 Test #61: rocprim.intrinsics_atomic ................... Passed 0.02 sec Start 62: rocprim.invoke_result 61/73 Test #62: rocprim.invoke_result ....................... Passed 0.01 sec Start 63: rocprim.warp_exchange 62/73 Test #63: rocprim.warp_exchange ....................... Passed 0.08 sec Start 64: rocprim.warp_load 63/73 Test #64: rocprim.warp_load ........................... Passed 0.08 sec Start 65: rocprim.warp_reduce 64/73 Test #65: rocprim.warp_reduce ......................... Passed 0.14 sec Start 66: rocprim.warp_scan 65/73 Test #66: rocprim.warp_scan ........................... Passed 0.20 sec Start 67: rocprim.warp_scan_disable_dpp_disable_dpp 66/73 Test #67: rocprim.warp_scan_disable_dpp_disable_dpp ... Passed 0.21 sec Start 68: rocprim.warp_sort 67/73 Test #68: rocprim.warp_sort ........................... Passed 0.09 sec Start 69: rocprim.warp_store 68/73 Test #69: rocprim.warp_store .......................... Passed 0.02 sec Start 70: rocprim.zip_iterator 69/73 Test #70: rocprim.zip_iterator ........................ Passed 0.02 sec Start 71: rocprim.accumulator_t 70/73 Test #71: rocprim.accumulator_t ....................... Passed 0.02 sec Start 72: hipgraph.basic 71/73 Test #72: hipgraph.basic .............................. Passed 0.02 sec Start 73: hipgraph.algs 72/73 Test #73: hipgraph.algs ............................... Passed 0.01 sec 73/73 Test #38: rocprim.device_segmented_radix_sort ......... Passed 31.97 sec 100% tests passed, 0 tests failed out of 73 Total Test time (real) = 71.80 sec ✅ test_rocprim.py PASSED ``` </details> <details> <summary>gfx1153 passed (click to see log)</summary> ``` INFO:root:++ Exec [/tmp/eble]$ ctest --test-dir /tmp/eble/rocm/bin/rocprim --output-o n-failure --parallel 1 --exclude-regex 'rocprim.lookback_reproducibility|rocprim.link ing|rocprim.device_merge_inplace|rocprim.device_merge_sort|rocprim.device_partition|r ocprim.device_radix_sort|rocprim.device_scan|rocprim.device_select|rocprim.device_fin d_first_of|rocprim.device_reduce_by_key' --timeout 60 Test project /tmp/eble/rocm/bin/rocprim Start 1: hip.device_api 1/73 Test #1: hip.device_api .............................. Passed 0.01 sec Start 2: hip.async_copy 2/73 Test #2: hip.async_copy .............................. Passed 0.01 sec Start 3: hip.ordered_block_id 3/73 Test #3: hip.ordered_block_id ........................ Passed 0.01 sec Start 4: rocprim.internal_merge_path 4/73 Test #4: rocprim.internal_merge_path ................. Passed 0.01 sec Start 5: rocprim.basic_test 5/73 Test #5: rocprim.basic_test .......................... Passed 0.01 sec Start 6: rocprim.arg_index_iterator 6/73 Test #6: rocprim.arg_index_iterator .................. Passed 0.01 sec Start 7: rocprim.temporary_storage_partitioning 7/73 Test #7: rocprim.temporary_storage_partitioning ...... Passed 0.01 sec Start 8: rocprim.block_adjacent_difference 8/73 Test #8: rocprim.block_adjacent_difference ........... Passed 2.94 sec Start 9: rocprim.block_discontinuity 9/73 Test #9: rocprim.block_discontinuity ................. Passed 21.10 sec Start 10: rocprim.bit_cast 10/73 Test #10: rocprim.bit_cast ............................ Passed 0.01 sec Start 11: rocprim.block_exchange 11/73 Test #11: rocprim.block_exchange ...................... Passed 2.20 sec Start 12: rocprim.block_histogram 12/73 Test #12: rocprim.block_histogram ..................... Passed 0.71 sec Start 13: rocprim.block_load_store 13/73 Test #13: rocprim.block_load_store .................... Passed 0.48 sec Start 14: rocprim.block_sort_merge 14/73 Test #14: rocprim.block_sort_merge .................... Passed 0.02 sec Start 15: rocprim.block_sort_merge_stable 15/73 Test #15: rocprim.block_sort_merge_stable ............. Passed 0.02 sec Start 16: rocprim.block_radix_rank 16/73 Test #16: rocprim.block_radix_rank .................... Passed 0.02 sec Start 17: rocprim.block_radix_sort 17/73 Test #17: rocprim.block_radix_sort .................... Passed 6.12 sec Start 18: rocprim.block_reduce 18/73 Test #18: rocprim.block_reduce ........................ Passed 0.31 sec Start 19: rocprim.block_run_length_decode 19/73 Test #19: rocprim.block_run_length_decode ............. Passed 0.68 sec Start 20: rocprim.block_scan 20/73 Test #20: rocprim.block_scan .......................... Passed 0.03 sec Start 21: rocprim.block_shuffle 21/73 Test #21: rocprim.block_shuffle ....................... Passed 3.63 sec Start 22: rocprim.block_sort_bitonic 22/73 Test #22: rocprim.block_sort_bitonic .................. Passed 19.34 sec Start 23: rocprim.config_dispatch 23/73 Test #23: rocprim.config_dispatch ..................... Passed 0.10 sec Start 24: rocprim.constant_iterator 24/73 Test #24: rocprim.constant_iterator ................... Passed 0.09 sec Start 25: rocprim.counting_iterator 25/73 Test #25: rocprim.counting_iterator ................... Passed 0.09 sec Start 26: rocprim.device_batch_memcpy 26/73 Test #26: rocprim.device_batch_memcpy ................. Passed 1.42 sec Start 27: rocprim.device_binary_search 27/73 Test #27: rocprim.device_binary_search ................ Passed 0.01 sec Start 28: rocprim.device_adjacent_difference 28/73 Test #28: rocprim.device_adjacent_difference .......... Passed 0.01 sec Start 29: rocprim.device_adjacent_find 29/73 Test #29: rocprim.device_adjacent_find ................ Passed 0.01 sec Start 30: rocprim.device_find_end 30/73 Test #30: rocprim.device_find_end ..................... Passed 0.01 sec Start 31: rocprim.device_histogram 31/73 Test #31: rocprim.device_histogram .................... Passed 8.77 sec Start 32: rocprim.device_merge 32/73 Test #32: rocprim.device_merge ........................ Passed 16.23 sec Start 33: rocprim.nth_element 33/73 Test #33: rocprim.nth_element ......................... Passed 0.01 sec Start 34: rocprim.device_partial_sort 34/73 Test #34: rocprim.device_partial_sort ................. Passed 0.02 sec Start 35: rocprim.device_reduce 35/73 Test #35: rocprim.device_reduce ....................... Passed 10.92 sec Start 36: rocprim.device_run_length_encode 36/73 Test #36: rocprim.device_run_length_encode ............ Passed 14.34 sec Start 37: rocprim.device_search 37/73 Test #37: rocprim.device_search ....................... Passed 0.01 sec Start 38: rocprim.device_segmented_radix_sort 38/73 Test #38: rocprim.device_segmented_radix_sort ......... Passed 38.28 sec Start 39: rocprim.device_search_n 39/73 Test #39: rocprim.device_search_n ..................... Passed 0.02 sec Start 40: rocprim.device_segmented_reduce 40/73 Test #40: rocprim.device_segmented_reduce ............. Passed 7.19 sec Start 41: rocprim.device_segmented_scan 41/73 Test #41: rocprim.device_segmented_scan ............... Passed 0.02 sec Start 42: rocprim.device_transform 42/73 Test #42: rocprim.device_transform .................... Passed 17.64 sec Start 43: rocprim.discard_iterator 43/73 Test #43: rocprim.discard_iterator .................... Passed 0.12 sec Start 44: rocprim.radix_key_codec 44/73 Test #44: rocprim.radix_key_codec ..................... Passed 0.01 sec Start 45: rocprim.predicate_iterator 45/73 Test #45: rocprim.predicate_iterator .................. Passed 0.08 sec Start 46: rocprim.reverse_iterator 46/73 Test #46: rocprim.reverse_iterator .................... Pas10:13:26 [46/1844] Start 47: rocprim.rocprim_tuple 47/73 Test #47: rocprim.rocprim_tuple ....................... Passed 0.01 sec Start 48: rocprim.rocprim_types 48/73 Test #48: rocprim.rocprim_types ....................... Passed 0.01 sec Start 49: rocprim.texture_cache_iterator 49/73 Test #49: rocprim.texture_cache_iterator .............. Passed 0.01 sec Start 50: rocprim.thread 50/73 Test #50: rocprim.thread .............................. Passed 0.08 sec Start 51: rocprim.thread_algos 51/73 Test #51: rocprim.thread_algos ........................ Passed 0.43 sec Start 52: rocprim.tuple 52/73 Test #52: rocprim.tuple ............................... Passed 0.01 sec Start 53: rocprim.utils_sort_checker 53/73 Test #53: rocprim.utils_sort_checker .................. Passed 0.01 sec Start 54: rocprim.transform_iterator 54/73 Test #54: rocprim.transform_iterator .................. Passed 0.12 sec Start 55: rocprim.type_traits_interface_cpp17 55/73 Test #55: rocprim.type_traits_interface_cpp17 ......... Passed 0.01 sec Start 56: rocprim.type_traits_interface_gnupp17 56/73 Test #56: rocprim.type_traits_interface_gnupp17 ....... Passed 0.01 sec Start 57: rocprim.type_traits_interface_cpp20 57/73 Test #57: rocprim.type_traits_interface_cpp20 ......... Passed 0.01 sec Start 58: rocprim.type_traits_interface_gnupp20 58/73 Test #58: rocprim.type_traits_interface_gnupp20 ....... Passed 0.01 sec Start 59: rocprim.no_half_operators 59/73 Test #59: rocprim.no_half_operators ................... Passed 0.01 sec Start 60: rocprim.intrinsics 60/73 Test #60: rocprim.intrinsics .......................... Passed 0.29 sec Start 61: rocprim.intrinsics_atomic 61/73 Test #61: rocprim.intrinsics_atomic ................... Pas10:13:27 [16/1844] Start 62: rocprim.invoke_result 62/73 Test #62: rocprim.invoke_result ....................... Passed 0.01 sec Start 63: rocprim.warp_exchange 63/73 Test #63: rocprim.warp_exchange ....................... Passed 0.09 sec Start 64: rocprim.warp_load 64/73 Test #64: rocprim.warp_load ........................... Passed 0.09 sec Start 65: rocprim.warp_reduce 65/73 Test #65: rocprim.warp_reduce ......................... Passed 0.17 sec Start 66: rocprim.warp_scan 66/73 Test #66: rocprim.warp_scan ........................... Passed 0.26 sec Start 67: rocprim.warp_scan_disable_dpp_disable_dpp 67/73 Test #67: rocprim.warp_scan_disable_dpp_disable_dpp ... Passed 0.26 sec Start 68: rocprim.warp_sort 68/73 Test #68: rocprim.warp_sort ........................... Passed 0.10 sec Start 69: rocprim.warp_store 69/73 Test #69: rocprim.warp_store .......................... Passed 0.01 sec Start 70: rocprim.zip_iterator 70/73 Test #70: rocprim.zip_iterator ........................ Passed 0.01 sec Start 71: rocprim.accumulator_t 71/73 Test #71: rocprim.accumulator_t ....................... Passed 0.01 sec Start 72: hipgraph.basic 72/73 Test #72: hipgraph.basic .............................. Passed 0.01 sec Start 73: hipgraph.algs 73/73 Test #73: hipgraph.algs ............................... Passed 0.01 sec 100% tests passed, 0 tests failed out of 73 Total Test time (real) = 175.34 sec ✅ test_rocprim.py PASSED ``` <detail> ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

pramenku and others added 25 commits September 22, 2018 12:03

add gfx906 as target

e9b0748

Since ROCm 1.9 has already VG20 support enabled so we can add gfx906 as target now. We can delete develop-gfx9 branch as no meaning to keep 2 branch now.

Merge pull request #32 from pramenku/patch-1

86133a7

add gfx906 as target

Update name and email for the package maintainer

02d6006

Use HIP API shfl functions rather than hc::

d4415cf

The HIP Platform should have it's own shuffle functions, and when using HIP-Clang, we don't want to use HCC specific functions.

Use HIP shfl functions for HIP-Clang

5508ed2

Bump rocPRIM version to 1.0.2.0

8b0f644

Ignore warnings about deprecated CUDA function(s) in HIP

b8298b5

Deprecated CUDA function are used in hip/nvcc_detail/hip_runtime_api.h.

Improve device merge sort tests with custom types

c564b83

Update .gitlab-ci.yml

5ced9c6

Update .gitlab-ci.yml

38c7f26

Update .gitlab-ci.yml

4610e0f

Update .gitignore

b7773ea

Add new file

919b1bc

Update .gitlab-ci-gputest.yml

3f3afe1

Update .gitlab-ci.yml

042eacc

Make sure the building is done on a server that has rocm installed

8368beb

Update .gitlab-ci.yml

ff41d04

Fix missing initial value in BlockScan::ExclusiveSum

c11dda7

Add gfx906 to test/extra (tests for install and package install)

c41212f

Print AMDGPU_TARGETS in CMake Summary

d82ec52

Add tests with half and char for block-level primitives

078cb46

Disable loopback scan for half, add compile-time specialization choosing

ac7d154

The compiler can't finish linking if half is used and loopback implementation is chosen using if.

Add tests with half and char for device-level primitives

f386dee

Replace reinterpret_cast with __builtin_memcpy

4344d4c

Usage of reinterpret_cast for bit-casting is undefined behavior. This change fixes `half` test failures on S9300 (Fiji): rocprim.hc.device_scan rocprim.hc.device_segmented_scan rocprim.hip.device_segmented_scan

Update tests for block_reduce

6af6cb6

ex-rzr assigned bragadeesh Nov 6, 2018

VincentSC changed the base branch from master to develop December 15, 2018 09:35

VincentSC changed the title ~~Our develop to master~~ Our develop with fixes to several issues Dec 15, 2018

saadrahim reviewed Dec 17, 2018

View reviewed changes

ex-rzr mentioned this pull request Dec 20, 2018

Building issue for rocPRIM exclusive_scan #35

Closed

saadrahim self-assigned this Jan 7, 2019

saadrahim approved these changes Jan 7, 2019

View reviewed changes

saadrahim merged commit 40d950b into develop Jan 7, 2019

saadrahim deleted the develop_stream branch January 7, 2019 19:16

ammallya pushed a commit that referenced this pull request Oct 28, 2025

Merge branch 'block_io_class' into 'master'

e0ae60e

Block IO: Block Load and Block Store Closes #33 See merge request amd/rocPRIM!25 [ROCm/rocPRIM commit: 568ef6d]

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Our develop with fixes to several issues#33

Our develop with fixes to several issues#33
saadrahim merged 25 commits into
developfrom
develop_stream

ex-rzr commented Nov 6, 2018

Uh oh!

VincentSC commented Dec 17, 2018

Uh oh!

saadrahim left a comment

Uh oh!

saadrahim left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ex-rzr commented Nov 6, 2018

Uh oh!

VincentSC commented Dec 17, 2018

Uh oh!

saadrahim left a comment

Choose a reason for hiding this comment

Uh oh!

saadrahim left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants