Develop stream 20200330#144
Merged
Merged
Conversation
Collaborator
neon60
commented
Mar 30, 2020
neon60
commented
- Add repeated numbers to test
- Fix the tolerance value at scan tests
- Minor fix for multi dimensional block
… use the new distribution
Adjusted get_random_data to include runs of same values See merge request amd/rocPRIM!240
Minor fix to flat_block_id See merge request amd/rocPRIM!244
Merged
saadrahim
approved these changes
Apr 1, 2020
arsenm
pushed a commit
to arsenm/rocPRIM
that referenced
this pull request
Jan 19, 2023
1. CUB's CountingInputIterator is supposed to be used with integer values 2. The current implementation of counting_iterator cannot handle floating point values properly because ptrdiff_t(float + 1 + ... + 1 n times) is not always equal to ptrdiff_t(float + n). See ROCm#144
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
1. CUB's CountingInputIterator is supposed to be used with integer values 2. The current implementation of counting_iterator cannot handle floating point values properly because ptrdiff_t(float + 1 + ... + 1 n times) is not always equal to ptrdiff_t(float + n). See #144 [ROCm/rocPRIM commit: b38041a]
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
…0330 Develop stream 20200330 [ROCm/rocPRIM commit: fa5c9e5]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.