Create Packages for hipclang#135
Merged
Merged
Conversation
eidenyoshida
approved these changes
Mar 16, 2020
eidenyoshida
approved these changes
Mar 25, 2020
assistant-librarian Bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
[rocPRIM] Avoid creating void reference type in device batch memcpy (#135) In the batch_memcpy_impl struct, we define two types based on the value of the InputBufferItType template argument. 1. input_type, set to the InputBufferItType's underlying value_type's value_type. 2. Alias, a type that's set using a std::conditional statement that examines the IsMemCpy boolean template arg, and may be set to either unsigned char or the type from (1). Later code creates a reference to (1). This causes problems when (1) is void. This change removes the definition of (1), since it does not appear to be used anywhere else in our repos (it's part of the detail namespace, so it's not public). However, this is not enough to fix the problem, since the compiler evaluates both sides of the std::conditional we use to define (2). To work around this, this change also adds a helper struct type, (AliasType) that uses template specialization on the IsMemCpy boolean to define the type that Alias will be assigned. This allows us to remove the std::conditional statement.
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
Create Packages for hipclang [ROCm/rocPRIM commit: 88681c5]
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
### Includes the following PRs: - #76 - #77 - #78 - #90 - #135 - #150 - #192 --------- Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com> Co-authored-by: Sander Bos <sander@streamhpc.com> Co-authored-by: Nara Prasetya <nara@streamhpc.com> Co-authored-by: Michael Kuron <1748330+mkuron@users.noreply.github.com> Co-authored-by: Wayne Franz <wayfranz@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.