Skip to content

Add rpath for rocff-test to help find libomp.so #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
malcolmroberts wants to merge 2 commits into from
Closed

Add rpath for rocff-test to help find libomp.so #628

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72052d0
Clean up linking rocff-test to omp and ensure that libomp.so exists.
malcolmroberts Jul 21, 2025
395cfd8
Add rpath for rocfft-test to help find libomp.
malcolmroberts Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions clients/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,7 @@ set( rocfft-test_include_dirs
${ROCM_CLANG_ROOT}/include
)

set( rocfft-test_link_libs
${FFTW_LIBRARIES} OpenMP::OpenMP_CXX
)
set( rocfft-test_link_libs ${FFTW_LIBRARIES} )

include( ../cmake/build-gtest.cmake )

Expand Down Expand Up @@ -216,6 +214,19 @@ if( NOT ROCFFT_BUILD_SCOPE )
set( ROCFFT_SQLITE_LIB SQLite::SQLite3)
endif()

option( BUILD_CLIENTS_TESTS_OPENMP "Build tests with OpenMP" ON )

if( BUILD_CLIENTS_TESTS_OPENMP )
find_package(OpenMP REQUIRED)
target_link_libraries( rocfft-test PRIVATE OpenMP::OpenMP_CXX
-L${HIP_CLANG_ROOT}/lib -Wl,-rpath=${HIP_CLANG_ROOT}/lib )
foreach(omplib ${OpenMP_CXX_LIBRARIES})
if(NOT EXISTS ${omplib})
message( FATAL_ERROR "OpenMP configuration mentions ${omplib} which does not exist." )
endif()
endforeach(omplib)
endif()

target_link_libraries( rocfft-test
PRIVATE
hip::device
Expand Down Expand Up @@ -270,20 +281,6 @@ target_include_directories( rocfft-test PRIVATE ${sqlite_local_SOURCE_DIR} )

set_property( TARGET rocfft-test APPEND PROPERTY LINK_LIBRARIES ${ROCFFT_SQLITE_LIB} )

option( BUILD_CLIENTS_TESTS_OPENMP "Build tests with OpenMP" ON )

if( BUILD_CLIENTS_TESTS_OPENMP )
find_package(OpenMP REQUIRED)
if( CMAKE_CXX_COMPILER MATCHES ".*/hipcc$" )
target_link_libraries( rocfft-test PRIVATE OpenMP::OpenMP_CXX -L${HIP_CLANG_ROOT}/lib -Wl,-rpath=${HIP_CLANG_ROOT}/lib )
target_include_directories( rocfft-test PRIVATE ${HIP_CLANG_ROOT}/include )
else()
if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
target_link_libraries( rocfft-test PRIVATE OpenMP::OpenMP_CXX )
endif()
endif()
endif()

if(FFTW_MULTITHREAD)
target_compile_options( rocfft-test PRIVATE -DFFTW_MULTITHREAD )
endif( )
Expand Down