Scope -Xarch_device -O3 to Avoid RTC Cache Errors on Windows#619
Closed
af-ayala wants to merge 2 commits into
Closed
Scope -Xarch_device -O3 to Avoid RTC Cache Errors on Windows#619af-ayala wants to merge 2 commits into
af-ayala wants to merge 2 commits into
Conversation
af-ayala
requested review from
eng-flavio-teixeira,
evetsso,
malcolmroberts and
regan-amd
as code owners
Contributor
|
Can you explain in more detail what's happening here? A side effect of this change should be that the callback tests will break in a debug build, as mentioned by the comment above your change. |
Contributor
|
Imported to ROCm/rocm-libraries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#solves 1239
Adding -Xarch_device -O3 causes the RTC-compiled kernel binaries to differ, leading to hash or ABI mismatches on Windows. These mismatches currently break kernel reuse from cache on Windows builds during repeated runs. For example:
rocfft-test.exe --gtest_filter=*rocfft_UnitTest.rtc_cache* --gtest_repeat=100This change limits the flag to non-Windows OSes to prevent RTC cache errors during testing.