Fixing the install script to throw errors correctly.#682
Merged
Conversation
Member
Author
|
The commit to simulate failure will be removed obviously. |
Member
Author
|
This was tested and correctly throws errors in the compile stage of Jenkins. |
This reverts commit 656e51e.
sdquiring
approved these changes
Sep 5, 2019
Contributor
sdquiring
left a comment
sdquiring
left a comment
There was a problem hiding this comment.
Great. Good to have the build fail in the correct place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.