Skip to content

Adding flag to install script to choose cpu lib#675

Merged
mahmoodw merged 2 commits into
ROCm:developfrom
mahmoodw:AddBlisOption
Sep 4, 2019
Merged

Adding flag to install script to choose cpu lib#675
mahmoodw merged 2 commits into
ROCm:developfrom
mahmoodw:AddBlisOption

Conversation

@mahmoodw
Copy link
Copy Markdown
Contributor

I have added a flag to the install script to be able to choose between the blis and lapack cpu libraries.

  • cpu_lib flag is set to blis by default.

I believe I should update the wiki page to include information on this flag when building the client.

@saadrahim
Copy link
Copy Markdown
Member

Will lapack build without openmp? I would like to quickly get SLES working.

@saadrahim saadrahim self-requested a review September 4, 2019 19:43
Comment thread install.sh Outdated
echo " [-o|--cov] Set tensile code_object_version (V2 or V3)"
echo " [-t|--test_local_path] Use a local path for tensile instead of remote GIT repot"
# echo " [--cuda] build library for cuda backend"
echo " [--cpu_lib] specify libary to use for cpu reference code in testing (blis or lapack)"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test library?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpu_ref_lib?

Copy link
Copy Markdown
Member

@saadrahim saadrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM maybe change the name of the option.

@mahmoodw mahmoodw merged commit 94f60f9 into ROCm:develop Sep 4, 2019
mlse-lib-jenkins pushed a commit that referenced this pull request May 12, 2021
* misc fixes and cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants