Skip to content

change install.sh tensile_branch to tensile_tag to match CMakeLists.txt#663

Merged
amdkila merged 1 commit into
ROCm:developfrom
amcamd:fix_install
Aug 20, 2019
Merged

change install.sh tensile_branch to tensile_tag to match CMakeLists.txt#663
amdkila merged 1 commit into
ROCm:developfrom
amcamd:fix_install

Conversation

@amcamd
Copy link
Copy Markdown
Contributor

@amcamd amcamd commented Aug 20, 2019

  • CMakeLists.txt defines tensile_tag
  • rocBLAS uses tensile_tag to pull a specific branch/hash/tag of Tensile
  • install.sh should call cmake with -Dtensile_tag not -Dtensile_branch so that it matches tensile_tag defined in CMakeLists.txt

Copy link
Copy Markdown
Member

@saadrahim saadrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@sdquiring sdquiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good.

Copy link
Copy Markdown
Contributor

@zaliu zaliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amdkila amdkila merged commit a6c36ff into ROCm:develop Aug 20, 2019
@amcamd amcamd deleted the fix_install branch August 26, 2019 15:37
mlse-lib-jenkins pushed a commit that referenced this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants